Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal: internal/cpu: add sha-ni detection for AMD64 #53084

Closed
tpaint opened this issue May 25, 2022 · 2 comments
Closed

proposal: internal/cpu: add sha-ni detection for AMD64 #53084

tpaint opened this issue May 25, 2022 · 2 comments
Labels
FrozenDueToAge Proposal
Milestone
Proposal

Comments

@tpaint
Copy link
Contributor

tpaint commented May 25, 2022

detect sha-ni instructions for AMD64 to support e.g., optimized sha-256 as described in proposal #50543 (#50543)
@gopherbot gopherbot added this to the Proposal milestone May 25, 2022
@tpaint tpaint mentioned this issue May 25, 2022
Closed
@randall77
Copy link
Contributor

I don't think we need the proposal process to change internal/cpu. It is internal after all. Just go ahead and change it.

Generally we only add things to internal/cpu when there is a user for them somewhere in the stdlib. Any internal/cpu changes can be part of whatever CL adds that use, or as a separate but associated CL.

@gopherbot
Copy link

Change https://go.dev/cl/408794 mentions this issue: internal/cpu: detect sha-ni instruction support for AMD64

gopherbot pushed a commit that referenced this issue Aug 15, 2022
@tpaint @randall77
internal/cpu: detect sha-ni instruction support for AMD64
f1b1557 
    addresses proposal #53084
    required by sha-256 change list developed for #50543

Change-Id: I5454d746fce069a7a4993d70dc5b0a5544f8eeaf
Reviewed-on: https://go-review.googlesource.com/c/go/+/408794
Run-TryBot: Keith Randall <khr@golang.org>
Reviewed-by: Martin Möhrmann <moehrmann@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
Run-TryBot: Keith Randall <khr@google.com>
@thaJeztah thaJeztah mentioned this issue Nov 29, 2022
Merged
@golang golang locked and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge Proposal
Projects
None yet
Milestone
Proposal
Development

No branches or pull requests
3 participants
@tpaint @randall77 @gopherbot