-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc/cgo/test: failure with gcc 10 [1.17 backport] #53050
Comments
Change https://go.dev/cl/408074 mentions this issue: |
I don't know. What would you prefer? |
I'd be inclined to skip the builder on the 1.17 branch, although I don't think there's much difference either way. (There are relatively few CLs on the release branch so it doesn't consume much of the builder's time, but I bet there also aren't that many folks building Go 1.17 from source on ARM64.) |
Then let's do that. |
I think it is okay to backport a CL that does the skip, CL 383554 (perhaps also incorporate CL 384269). |
Approved. Test skip with little risk. |
@bsiegert The builder appears to be passing on release-branch.go1.17 now (https://build.golang.org/?branch=release-branch.go1.17). Was there a change on the builder to resolve this issue, or is this a flaky failure? Do we still need to backport CL 383554 and/or CL 384269 for this issue? Thanks. |
Change https://go.dev/cl/415074 mentions this issue: |
It does appear the failure isn't consistent for some reason (that I don't understand), but it happened again on the latest commit on the release branch (see here). Made the two backport CLs. |
Change https://go.dev/cl/415075 mentions this issue: |
Closed by merging 651a8d8 to release-branch.go1.17. |
The previous workaround for issue #39466 only disabled this test for Linux. However, the issue manifests for all arm64 systems with gcc 9.4 and above. The new netbsd-arm64 builder uses NetBSD-current with gcc 10.3, so it fails in the same way. Updates #39466. For #53050. Change-Id: I276a99a5e60914e5c22f74a680e461bea17cfe92 Reviewed-on: https://go-review.googlesource.com/c/go/+/383554 Trust: Benny Siegert <bsiegert@gmail.com> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org> (cherry picked from commit 1d60513) Reviewed-on: https://go-review.googlesource.com/c/go/+/415074 Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com>
…-arm64 CL 415074 disables testing cgo internal linking on all ARM64 but Windows, because it doesn't work with newer GCC. But - darwin-arm64 works, and it does not use GCC - we don't support cgo internal linking on windows-arm64 anyway. This CL fixes the condition. Fixes #53050. Change-Id: I9eb7b81ef75e482f5e95d2edae4863ba21396432 Reviewed-on: https://go-review.googlesource.com/c/go/+/384269 Trust: Cherry Mui <cherryyz@google.com> Run-TryBot: Cherry Mui <cherryyz@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org> (cherry picked from commit e4ca3fa) Reviewed-on: https://go-review.googlesource.com/c/go/+/415075 Reviewed-by: Cherry Mui <cherryyz@google.com> Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
@bcmills requested issue #50987 to be considered for backport to the next 1.17 minor release.
The text was updated successfully, but these errors were encountered: