Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc/cgo/testsanitizers: occasional hangs in TestTSAN/tsan12 [1.17 backport] #53042

Closed
gopherbot opened this issue May 24, 2022 · 3 comments
Closed

misc/cgo/testsanitizers: occasional hangs in TestTSAN/tsan12 [1.17 backport] #53042

gopherbot opened this issue May 24, 2022 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.17.11

Comments

@gopherbot
Copy link

@bcmills requested issue #52998 to be considered for backport to the next 1.17 minor release.

@gopherbot, please backport to Go 1.18 and 1.17. This is a test-only fix for a test that occasionally deadlocks, which can cause TryBot stalls and spurious failures on release branches.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label May 24, 2022
@gopherbot gopherbot mentioned this issue May 24, 2022
Closed
@gopherbot gopherbot added this to the Go1.17.11 milestone May 24, 2022
@gopherbot
Copy link
Author

Change https://go.dev/cl/408115 mentions this issue: [release-branch.go1.17] misc/cgo/testsanitizers: use buffered channel in tsan12.go

@bcmills bcmills added the Testing An issue that has been verified to require only test changes, not just a test failure. label May 24, 2022
@toothrot toothrot added the CherryPickApproved Used during the release process for point releases label May 25, 2022
@toothrot
Copy link
Contributor

Approved. Low risk, trivial change that fixes testing issues.

@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label May 25, 2022
@gopherbot
Copy link
Author

Closed by merging 65701ad to release-branch.go1.17.

gopherbot pushed a commit that referenced this issue May 25, 2022
@cherrymui @toothrot
[release-branch.go1.17] misc/cgo/testsanitizers: use buffered channel…
65701ad 
… in tsan12.go

os/signal.Notify requires that "the caller must ensure that c has
sufficient buffer space to keep up with the expected signal rate"
as it does a nonblocking send when it receives a signal. The test
currently using a unbuffered channel, which means it may miss the
signal if the signal arrives before the channel receive operation.

Fixes #53042.
Updates #52998.

Change-Id: Icdcab9396d735506480ef880fb45a4669fa7cc8f
Reviewed-on: https://go-review.googlesource.com/c/go/+/407888
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit 62e1302)
Reviewed-on: https://go-review.googlesource.com/c/go/+/408115
@golang golang locked and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.17.11
Development

No branches or pull requests
3 participants
@toothrot @bcmills @gopherbot