Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/crypto/acme: not possible to remove contact information #53031

Open
mateusz834 opened this issue May 23, 2022 · 1 comment
Open

x/crypto/acme: not possible to remove contact information #53031

mateusz834 opened this issue May 23, 2022 · 1 comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@mateusz834
Copy link
Member

What version of Go are you using (go version)?

$ go version
go version go1.18.2 linux/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN="/home/mateusz/go/bin"
GOCACHE="/home/mateusz/.cache/go-build"
GOENV="/home/mateusz/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/mateusz/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/mateusz/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/lib/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.18.2"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build947326088=/tmp/go-build -gno-record-gcc-switches"

What did you do?

c := &acme.Client{
	DirectoryURL: "https://acme-staging-v02.api.letsencrypt.org/directory",
	Key:          key,
}
c.UpdateReg(ctx, &acme.Account{
	Contact: nil,
})

What did you expect to see?

Contact information removed

What did you see instead?

Contact information didn't change

c := &acme.Client{
	DirectoryURL: "https://acme-staging-v02.api.letsencrypt.org/directory",
	Key:          key,
}
acct, _ := c.GetReg(ctx, "")
fmt.Println(acct.Contact) // ["mailto:email@gmail.com"]
@gopherbot gopherbot added this to the Unreleased milestone May 23, 2022
@mateusz834 mateusz834 changed the title x/crypto: acme: not possible to remove contact information x/crypto/acme: not possible to remove contact information May 23, 2022
@mateusz834
Copy link
Member Author

It is caused by the "omitempty": https://github.com/golang/crypto/blob/6f7dac9698988af7b704298c9fd8adf58e1d30c0/acme/rfc8555.go#L109

@seankhliao seankhliao added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@gopherbot @seankhliao @mateusz834