Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing: TempDir RemoveAll cleanup failures with "The process cannot access the file because it is being used by another process." [1.18 backport] #52986

Closed
gopherbot opened this issue May 19, 2022 · 4 comments
Closed

testing: TempDir RemoveAll cleanup failures with "The process cannot access the file because it is being used by another process." [1.18 backport] #52986

gopherbot opened this issue May 19, 2022 · 4 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.18.5

Comments

@gopherbot
Copy link

@ianlancetaylor requested issue #51442 to be considered for backport to the next 1.18 minor release.

@gopherbot Please open backport to 1.18.

At least one person is encountering this problem in 1.18. There are workarounds but they are awkward. The fix would be harder to backport to earlier releases.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label May 19, 2022
@gopherbot gopherbot mentioned this issue May 19, 2022
Closed
@gopherbot gopherbot added this to the Go1.18.3 milestone May 19, 2022
@AbhineetJain AbhineetJain mentioned this issue May 20, 2022
Merged
3 tasks
@gopherbot
Copy link
Author

Change https://go.dev/cl/407877 mentions this issue: [release-branch.go1.18] testing: include ERROR_SHARING_VIOLATION in Windows cleanup retries

@jLopezbarb jLopezbarb mentioned this issue May 26, 2022
Closed
@dmitshur dmitshur modified the milestones: Go1.18.3, Go1.18.4 Jun 1, 2022
@xiantang xiantang mentioned this issue Jun 6, 2022
Open
@jLopezbarb jLopezbarb mentioned this issue Jun 9, 2022
Merged
@heschi heschi added the CherryPickApproved Used during the release process for point releases label Jun 15, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jun 15, 2022
@gopherbot gopherbot modified the milestones: Go1.18.4, Go1.18.5 Jul 12, 2022
@bhasden
Copy link

bhasden commented Jul 13, 2022

Out of curiosity, what causes some items to be included in a release and some items to be deferred?

@ianlancetaylor
Copy link
Contributor

Our guidelines are described at https://go.dev/wiki/MinorReleases.

@gopherbot
Copy link
Author

Closed by merging d06c911 to release-branch.go1.18.

gopherbot pushed a commit that referenced this issue Jul 25, 2022
@cherrymui
[release-branch.go1.18] testing: include ERROR_SHARING_VIOLATION in W…
d06c911 
…indows cleanup retries

Fixes #52986
Updates #51442
Updates #50051

Change-Id: I1bfbc08c907077467fd50febbec6299a9b73af41
Reviewed-on: https://go-review.googlesource.com/c/go/+/388916
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
(cherry picked from commit eeb9f09)
Reviewed-on: https://go-review.googlesource.com/c/go/+/407877
Reviewed-by: Nooras Saba‎ <saba@golang.org>
Auto-Submit: Bryan Mills <bcmills@google.com>
@golang golang locked and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.18.5
Development

No branches or pull requests
5 participants
@bhasden @dmitshur @ianlancetaylor @gopherbot @heschi