Skip to content

x/tools/gopls/internal/vulncheck: automate copying of x/vuln/cmd/govulncheck logic #52985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hyangah opened this issue May 18, 2022 · 2 comments
Closed

x/tools/gopls/internal/vulncheck: automate copying of x/vuln/cmd/govulncheck logic #52985

hyangah opened this issue May 18, 2022 · 2 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Milestone
gopls/v0.9.0

Comments

@hyangah
Copy link
Contributor

hyangah commented May 18, 2022

Majority of x/tools/gopls/internal/vulncheck (the core of gopls vulncheck) is copied from x/vuln/cmd/govulncheck.
(the motivation was to avoid installing an extra tool for IDE integration).
Either reuse the API of govulncheck (if it ever gets exported), or automate the code copying.
@hyangah hyangah added gopls Issues related to the Go language server, gopls. vulncheck labels May 18, 2022
@hyangah hyangah added this to the gopls/v0.9.0 milestone May 18, 2022
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label May 18, 2022
@hyangah
Copy link
Contributor Author

hyangah commented May 18, 2022

https://go-review.googlesource.com/c/tools/+/405997 is already merged :-)

@jba jba closed this as completed May 19, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/407114 mentions this issue: gopls/internal/vulncheck: use internal/govulncheck

gopherbot pushed a commit to golang/tools that referenced this issue May 31, 2022
@jba
gopls/internal/vulncheck: use internal/govulncheck
1ff52e2 
Copy the x/vuln/cmd/govulncheck/internal/govulncheck package
and use it in internal/vulncheck.

Fixes golang/go#52985.

Change-Id: I3fb16b3d486ac462fca36aa53fd46e576041102d
Reviewed-on: https://go-review.googlesource.com/c/tools/+/407114
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@rsc rsc unassigned jba Jun 22, 2022
@julieqiu julieqiu added the vulncheck or vulndb Issues for the x/vuln or x/vulndb repo label Sep 8, 2022
@golang golang locked and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Projects
Go Security
Status: No status
Milestone
gopls/v0.9.0
Development

No branches or pull requests
4 participants
@hyangah @julieqiu @gopherbot @jba