Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: switch to new diff implementation (umbrella) #52967

Closed
5 tasks done
findleyr opened this issue May 18, 2022 · 6 comments
Closed
5 tasks done

x/tools/gopls: switch to new diff implementation (umbrella) #52967

findleyr opened this issue May 18, 2022 · 6 comments
Assignees
@findleyr
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository. umbrella
Milestone
gopls/v0.15.0

Comments

@findleyr
Copy link
Contributor

findleyr commented May 18, 2022 •
edited

This is an umbrella issue tracking the work to switch to the new diff implementation being worked on by @pjweinb in https://go.dev/cl/396855.

Rough outline of steps:

  • x/tools/gopls: a new internal diff implementation #52966: Land the new implementation, with the "both" algorithm option comparing old and new.
  • Run this for a week or so among the team or any early adopters.
  • Enable "both" on the vscode-go nightly release, with bug reporting enabled.
  • Make the new diff algorithm the default, with an option to revert to the old diff algorithm.
  • Remove the old diff algorithm, and the dependency on go-diff.
@findleyr findleyr added this to the gopls/later milestone May 18, 2022
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels May 18, 2022
@ansaba ansaba modified the milestones: gopls/later, gopls/v0.9.2 Jul 14, 2022
@gopherbot
Copy link

Change https://go.dev/cl/419981 mentions this issue: internal/lsp/source: enable the new diff with allExperiments

gopherbot pushed a commit to golang/tools that referenced this issue Aug 1, 2022
@findleyr
internal/lsp/source: enable the new diff with allExperiments
9f65685 
When enabling all experiments (done by VS Code nightly), switch to the
checked version of the new diff implementation.

Also remove some experimental settings that are now on by default.

Updates golang/go#52967

Change-Id: Id272c4a646006a739e49d48f0f09b2f8b0982bab
Reviewed-on: https://go-review.googlesource.com/c/tools/+/419981
gopls-CI: kokoro <noreply+kokoro@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Peter Weinberger <pjw@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@findleyr findleyr modified the milestones: gopls/v0.9.2, gopls/v0.10.0 Aug 4, 2022
@gopherbot
Copy link

Change https://go.dev/cl/427534 mentions this issue: internal/lsp/source: switch the default diff algorithm to "checked"

gopherbot pushed a commit to golang/tools that referenced this issue Oct 10, 2022
@findleyr
internal/lsp/source: switch the default diff algorithm to "checked"
19cfa79 
We've been using this setting in experimental for some time without
issue, so switch it to default.

For golang/go#52967

Change-Id: Ib4d786e689d4b0f009195cc86d7dd5d8269cf424
Reviewed-on: https://go-review.googlesource.com/c/tools/+/427534
Reviewed-by: Peter Weinberger <pjw@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@findleyr findleyr modified the milestones: gopls/v0.10.0, gopls/v0.11.0 Oct 11, 2022
@findleyr findleyr modified the milestones: gopls/v0.12.0, gopls/v0.13.0 Mar 27, 2023
@bkessler-go bkessler-go assigned findleyr and unassigned pjweinb Jul 6, 2023
@gopherbot
Copy link

Change https://go.dev/cl/520135 mentions this issue: gopls/internal/lsp: switch default diff to "new"

gopherbot pushed a commit to golang/tools that referenced this issue Aug 16, 2023
@findleyr
gopls/internal/lsp: switch default diff to "new"
0286c38 
As the next step in the diff migration, stop running both diffs by
default.

For golang/go#52967

Change-Id: I4b1a434d13f4349feabc5eb0daf3b9e8d56f99aa
Reviewed-on: https://go-review.googlesource.com/c/tools/+/520135
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Peter Weinberger <pjw@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
@findleyr
Copy link
Contributor Author

Done for v0.14.0. Will delete the old diff in v0.15.0.

@findleyr findleyr modified the milestones: gopls/v0.14.0, gopls/v0.15.0 Aug 16, 2023
@qiulaidongfeng qiulaidongfeng mentioned this issue Dec 7, 2023
Closed
@gopherbot
Copy link

Change https://go.dev/cl/548175 mentions this issue: gopls/internal: remove old diff

@gopherbot
Copy link

Change https://go.dev/cl/548856 mentions this issue: gopls/internal: use new diff implementation

gopherbot pushed a commit to golang/tools that referenced this issue Dec 15, 2023
@qiulaidongfeng @gopherbot
gopls/internal: remove old diff
4d2b6e1 
For golang/go#52967

Change-Id: I3afdeffa739311942795389bf2607c942bd8fc68
GitHub-Last-Rev: f95ca66
GitHub-Pull-Request: #465
Reviewed-on: https://go-review.googlesource.com/c/tools/+/548175
Reviewed-by: Robert Findley <rfindley@google.com>
Auto-Submit: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@findleyr findleyr

Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository. umbrella
Projects
None yet
Milestone
gopls/v0.15.0
Development

No branches or pull requests
4 participants
@ansaba @pjweinb @gopherbot @findleyr