Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: a new internal diff implementation #52966

Closed
findleyr opened this issue May 18, 2022 · 3 comments
Closed

x/tools/gopls: a new internal diff implementation #52966

findleyr opened this issue May 18, 2022 · 3 comments
Assignees
@pjweinb
Labels
FrozenDueToAge gopls/corruption Issues related to file corruption in gopls gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.9.2

Comments

@findleyr
Copy link
Contributor

findleyr commented May 18, 2022 •
edited

This is a tracking issue for landing https://go.dev/cl/396855, implementing a new internal diff algorithm to reduce our external dependencies.

(I will file a separate umbrella issue for the entire process of making this switch. This issue exists for milestone tracking).
@findleyr findleyr added this to the gopls/v0.9.0 milestone May 18, 2022
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels May 18, 2022
@findleyr findleyr mentioned this issue May 18, 2022
Closed
5 tasks
@findleyr findleyr added the gopls/corruption Issues related to file corruption in gopls label May 18, 2022
@mvdan
Copy link
Member

mvdan commented May 18, 2022

Is the CL link wrong? I see:

internal/lsp: add an option to get notified of bug reports

@findleyr
Copy link
Contributor Author

Is the CL link wrong?

Whoops, indeed! Fixed. Thanks.

@findleyr findleyr modified the milestones: gopls/v0.9.0, gopls/v0.9.1 Jun 27, 2022
@findleyr findleyr modified the milestones: gopls/v0.9.1, gopls/v0.9.2 Jul 13, 2022
@gopherbot
Copy link

Change https://go.dev/cl/396855 mentions this issue: internal/lsp/diff: new diff implementation to replace go-diff

@golang golang locked and limited conversation to collaborators Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pjweinb pjweinb

Labels
FrozenDueToAge gopls/corruption Issues related to file corruption in gopls gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.9.2
Development

No branches or pull requests
4 participants
@mvdan @pjweinb @gopherbot @findleyr