Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/nettest: TestTestConn/TCP/RacyRead failures with err.Timeout() = false on windows/arm64 #52893

Closed
bcmills opened this issue May 13, 2022 · 6 comments
Closed

x/net/nettest: TestTestConn/TCP/RacyRead failures with err.Timeout() = false on windows/arm64 #52893

bcmills opened this issue May 13, 2022 · 6 comments
Labels
arch-arm64 FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows
Milestone
Backlog

Comments

@bcmills
Copy link
Contributor

bcmills commented May 13, 2022 •
edited 

--- FAIL: TestTestConn (0.60s)
    --- FAIL: TestTestConn/TCP (0.58s)
        --- FAIL: TestTestConn/TCP/RacyRead (0.05s)
            conntest.go:165: err.Timeout() = false, want true
FAIL
FAIL	golang.org/x/net/nettest	0.974s

Probably a good first step would be to update the test to log more details about err, per https://go.dev/wiki/CodeReviewComments#useful-test-failures.

greplogs -l -e 'FAIL: TestTestConn .*(?:\n[ ]+.*)* err\.Timeout' --since=2021-01-01
2022-05-12T04:08:07-2871e0c-900ae5b/windows-arm64-11
2022-02-12T05:44:16-cd36cc0-f14ad78/windows-arm64-11

(CC @neild @ianlancetaylor @golang/windows)
@bcmills bcmills added OS-Windows NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. arch-arm64 labels May 13, 2022
@bcmills bcmills added this to the Backlog milestone May 13, 2022
@ZekeLu ZekeLu mentioned this issue May 14, 2022
Closed
@gopherbot
Copy link

Change https://go.dev/cl/406435 mentions this issue: nettest: log more details about err for checkForTimeoutError

gopherbot pushed a commit to golang/net that referenced this issue May 16, 2022
@ZekeLu @gopherbot
nettest: log more details about err for checkForTimeoutError
20f9603 
For golang/go#52893

Change-Id: I2897c3f22b670af0aa2df1edbc9bbebdf1bafe59
GitHub-Last-Rev: bdccfc3
GitHub-Pull-Request: #132
Reviewed-on: https://go-review.googlesource.com/c/net/+/406435
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
@bcmills
Copy link
Contributor Author

bcmills commented May 24, 2022

Thanks @ZekeLu for the added logging! We now have error text for the underlying error:

--- FAIL: TestTestConn (0.53s)
    --- FAIL: TestTestConn/TCP (0.52s)
        --- FAIL: TestTestConn/TCP/RacyRead (0.04s)
            conntest.go:165: got error: read tcp 127.0.0.1:49920->127.0.0.1:49919: wsarecv: The I/O operation has been aborted because of either a thread exit or an application request., want err.Timeout() = true
FAIL
FAIL	golang.org/x/net/nettest	1.173s

greplogs -l -e 'FAIL: TestTestConn .*(?:\n[ ]+.*)* err\.Timeout' --since=2022-05-13
2022-05-23T22:10:24-2e3eb7b-2138124/windows-arm64-10

@bcmills bcmills changed the title x/net/nettest: TestTestConn/TCP/RacyRead failures with err.Timeout() = false on windows-arm64-11 x/net/nettest: TestTestConn/TCP/RacyRead failures with err.Timeout() = false on windows/arm64 May 24, 2022
@bcmills
Copy link
Contributor Author

bcmills commented May 24, 2022

Curiously, that error text is not listed among the WSA error codes at https://docs.microsoft.com/en-us/windows/win32/winsock/windows-sockets-error-codes-2. 😵‍💫

This error code seems to be ERROR_OPERATION_ABORTED.
(https://docs.microsoft.com/en-us/windows/win32/debug/system-error-codes--500-999-)

@bcmills
Copy link
Contributor Author

bcmills commented Jun 14, 2022

greplogs -l -e 'FAIL: TestTestConn .*(?:\n[ ]+.*)* err\.Timeout' --since=2022-05-24
2022-06-06T20:48:03-c960675-a71ca3d/windows-arm64-10
2022-06-01T22:59:44-c960675-46ab7a5/windows-arm64-11

@gopherbot
Copy link

Change https://go.dev/cl/412137 mentions this issue: nettest: skip known failure mode of TestTestConn/TCP/RacyRead on windows/arm64

gopherbot pushed a commit to golang/net that referenced this issue Jun 14, 2022
@gopherbot
nettest: skip known failure mode of TestTestConn/TCP/RacyRead on wind…
fb05da6 
…ows/arm64

For golang/go#52893.

Change-Id: Icb8ec3512608ec7f7fcdafc62161bc836c84605b
Reviewed-on: https://go-review.googlesource.com/c/net/+/412137
Run-TryBot: Bryan Mills <bcmills@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
@bcmills bcmills mentioned this issue Jun 28, 2022
Closed
@bcmills
Copy link
Contributor Author

bcmills commented Jul 11, 2022

Duplicate of #53584

@bcmills bcmills marked this as a duplicate of #53584 Jul 11, 2022
@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Jul 11, 2022
WeiminShang added a commit to WeiminShang/net that referenced this issue Nov 16, 2022
@WeiminShang @gopherbot
nettest: log more details about err for checkForTimeoutError
314f518 
For golang/go#52893

Change-Id: I2897c3f22b670af0aa2df1edbc9bbebdf1bafe59
GitHub-Last-Rev: bdccfc34beedc504a7ab4b3e903f1e09753ff85f
GitHub-Pull-Request: golang/net#132
Reviewed-on: https://go-review.googlesource.com/c/net/+/406435
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
WeiminShang added a commit to WeiminShang/net that referenced this issue Nov 16, 2022
@WeiminShang @gopherbot
nettest: skip known failure mode of TestTestConn/TCP/RacyRead on wind…
47c33a6 
…ows/arm64

For golang/go#52893.

Change-Id: Icb8ec3512608ec7f7fcdafc62161bc836c84605b
Reviewed-on: https://go-review.googlesource.com/c/net/+/412137
Run-TryBot: Bryan Mills <bcmills@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
@golang golang locked and limited conversation to collaborators Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
arch-arm64 FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@bcmills @gopherbot