-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/net/nettest: TestTestConn/TCP/RacyRead failures with err.Timeout() = false
on windows/arm64
#52893
Comments
Change https://go.dev/cl/406435 mentions this issue: |
For golang/go#52893 Change-Id: I2897c3f22b670af0aa2df1edbc9bbebdf1bafe59 GitHub-Last-Rev: bdccfc3 GitHub-Pull-Request: #132 Reviewed-on: https://go-review.googlesource.com/c/net/+/406435 Run-TryBot: Bryan Mills <bcmills@google.com> Reviewed-by: Damien Neil <dneil@google.com> Auto-Submit: Bryan Mills <bcmills@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Bryan Mills <bcmills@google.com>
Thanks @ZekeLu for the added logging! We now have error text for the underlying error:
|
err.Timeout() = false
on windows-arm64-11err.Timeout() = false
on windows/arm64
Curiously, that error text is not listed among the WSA error codes at https://docs.microsoft.com/en-us/windows/win32/winsock/windows-sockets-error-codes-2. 😵💫 This error code seems to be |
|
Change https://go.dev/cl/412137 mentions this issue: |
…ows/arm64 For golang/go#52893. Change-Id: Icb8ec3512608ec7f7fcdafc62161bc836c84605b Reviewed-on: https://go-review.googlesource.com/c/net/+/412137 Run-TryBot: Bryan Mills <bcmills@google.com> Auto-Submit: Bryan Mills <bcmills@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@google.com>
Duplicate of #53584 |
For golang/go#52893 Change-Id: I2897c3f22b670af0aa2df1edbc9bbebdf1bafe59 GitHub-Last-Rev: bdccfc34beedc504a7ab4b3e903f1e09753ff85f GitHub-Pull-Request: golang/net#132 Reviewed-on: https://go-review.googlesource.com/c/net/+/406435 Run-TryBot: Bryan Mills <bcmills@google.com> Reviewed-by: Damien Neil <dneil@google.com> Auto-Submit: Bryan Mills <bcmills@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Bryan Mills <bcmills@google.com>
…ows/arm64 For golang/go#52893. Change-Id: Icb8ec3512608ec7f7fcdafc62161bc836c84605b Reviewed-on: https://go-review.googlesource.com/c/net/+/412137 Run-TryBot: Bryan Mills <bcmills@google.com> Auto-Submit: Bryan Mills <bcmills@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@google.com>
Probably a good first step would be to update the test to log more details about
err
, per https://go.dev/wiki/CodeReviewComments#useful-test-failures.greplogs -l -e 'FAIL: TestTestConn .*(?:\n[ ]+.*)* err\.Timeout' --since=2021-01-01
2022-05-12T04:08:07-2871e0c-900ae5b/windows-arm64-11
2022-02-12T05:44:16-cd36cc0-f14ad78/windows-arm64-11
(CC @neild @ianlancetaylor @golang/windows)
The text was updated successfully, but these errors were encountered: