Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: module index [freeze exception] #52876

Closed
matloob opened this issue May 12, 2022 · 8 comments
Closed

cmd/go: module index [freeze exception] #52876

matloob opened this issue May 12, 2022 · 8 comments
Labels
FrozenDueToAge GoCommand cmd/go NeedsFix The path to resolution is known, but the work has not been done. Performance
Milestone
Go1.19

Comments

@matloob
Copy link
Contributor

matloob commented May 12, 2022

Hi,

I'd like to request a freeze exception for the work on the cmd/go module index. All the CLs have been mailed out but we need a little more time to get the reviews through.

Thanks!
Michael
@mvdan
Copy link
Member

mvdan commented May 12, 2022

What is the module index? Any links you can share?

@thepudds
Copy link
Contributor

Hi @mvdan, there is a stack of CLs here, but I’m not sure if there is a general overview somewhere:

https://go-review.googlesource.com/c/go/+/398415/30

As I understand it, it is to reduce reliance on scanning the existing module cache, presumably for performance reasons.

@seankhliao seankhliao changed the title cmd/go: freeze exception for module index cmd/go: module index [freeze exception] May 12, 2022
@seankhliao seankhliao added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label May 12, 2022
@seankhliao seankhliao added this to the Go1.19 milestone May 12, 2022
@seankhliao
Copy link
Member

cc @golang/release

@heschi
Copy link
Contributor

heschi commented May 13, 2022

Approved: the go command doesn't get much testing until the beta anyway, and the change doesn't seem likely to cause problems for other parts of the project.

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels May 14, 2022
@dmitshur
Copy link
Contributor

dmitshur commented Jun 8, 2022 •
edited

@matloob With #53290 resolved, should this be closed too, or is there more to do?

@dmitshur dmitshur added the GoCommand cmd/go label Jun 22, 2022
@gopherbot
Copy link

Change https://go.dev/cl/413815 mentions this issue: cmd/go: add per-package indexing for modules outside mod cache

gopherbot pushed a commit that referenced this issue Jun 24, 2022
@matloob
cmd/go: add per-package indexing for modules outside mod cache
5a1c5b8 
Packages outside the module cache including the standard library will be
indexed individually rather than as a whole module.

For #52876

Change-Id: I142dad6a790e9e8eb4dc6430a588fbfa86552e49
Reviewed-on: https://go-review.googlesource.com/c/go/+/413815
Reviewed-by: Michael Matloob <matloob@golang.org>
Run-TryBot: Michael Matloob <matloob@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@bcmills
Copy link
Contributor

bcmills commented Jul 1, 2022

I just noticed that we had filed #31417 a couple of years ago for this. (Just adding a cross-reference here.)

@bcmills
Copy link
Contributor

bcmills commented Aug 2, 2022

This is done.

@bcmills bcmills closed this as completed Aug 2, 2022
jproberts pushed a commit to jproberts/go that referenced this issue Aug 10, 2022
@matloob @jproberts
cmd/go: add per-package indexing for modules outside mod cache
fc33f1f 
Packages outside the module cache including the standard library will be
indexed individually rather than as a whole module.

For golang#52876

Change-Id: I142dad6a790e9e8eb4dc6430a588fbfa86552e49
Reviewed-on: https://go-review.googlesource.com/c/go/+/413815
Reviewed-by: Michael Matloob <matloob@golang.org>
Run-TryBot: Michael Matloob <matloob@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge GoCommand cmd/go NeedsFix The path to resolution is known, but the work has not been done. Performance
Projects
Release Status & Release Blockers
Status: Done
Milestone
Go1.19
Development

No branches or pull requests
8 participants
@dmitshur @mvdan @bcmills @gopherbot @seankhliao @matloob @thepudds @heschi