Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: The analyzers documentation doesn't mention some analyzers #52874

Closed
pjweinb opened this issue May 12, 2022 · 4 comments
Closed

x/tools/gopls: The analyzers documentation doesn't mention some analyzers #52874

pjweinb opened this issue May 12, 2022 · 4 comments
Assignees
@pjweinb
Labels
Documentation FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.10.0

Comments

@pjweinb
Copy link

pjweinb commented May 12, 2022

gopls version

What did you do?

I read x/tools/gopls/doc/analyzers.md to try to find the setting that would turn off useless messages labelled QF1003.

What did you expect to see?

Some mention of QF1003, or a hint about where to find information about it.

What did you see instead?

nothing.

Editor and settings
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels May 12, 2022
@gopherbot gopherbot added this to the Unreleased milestone May 12, 2022
@pjweinb
Copy link
Author

pjweinb commented May 13, 2022

The code at x/tools/gopls/docgenerate.go:101 says "// Don't yet add staticcheck analyzers".

@dominikh
Copy link
Member

In the meantime, all of Staticcheck's analyzers are documented at https://staticcheck.io/docs/checks/.

@findleyr
Copy link
Contributor

I think we should just clearly link to staticcheck docs.

@findleyr findleyr modified the milestones: Unreleased, gopls/later May 15, 2022
@gopherbot
Copy link

Change https://go.dev/cl/428595 mentions this issue: gopls : add a mention of staticcheck to settings documentation

@findleyr findleyr modified the milestones: gopls/later, gopls/v0.10.0 Oct 20, 2022
@golang golang locked and limited conversation to collaborators Oct 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pjweinb pjweinb

Labels
Documentation FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.10.0
Development

No branches or pull requests
4 participants
@dominikh @pjweinb @gopherbot @findleyr