You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
seankhliao
changed the title
apidiff: ignore "internal" packages during comparison
x/exp/apidiff: ignore "internal" packages during comparison
May 12, 2022
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
Yes (of apidiff).
What did you do?
We use apidiff in a Go project to prevent merging of PRs which break the API:
https://github.com/kubernetes/klog/blob/main/hack/verify-apidiff.sh
One PR removes an exported function from "internal/serialize": kubernetes/klog#326
What did you expect to see?
apidiff should not complain.
What did you see instead?
https://github.com/kubernetes/klog/runs/6372237998?check_suite_focus=true
The text was updated successfully, but these errors were encountered: