Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: migrate to jsonrpc2_v2 #52838

Open
findleyr opened this issue May 10, 2022 · 2 comments
Open

x/tools/gopls: migrate to jsonrpc2_v2 #52838

findleyr opened this issue May 10, 2022 · 2 comments
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/backlog

Comments

@findleyr
Copy link
Contributor

The new version of the jsonrpc2 package (authored by @ianthehat) has improved APIs and shutdown semantics. @bcmills has also recently worked on improving its concurrency model.

This issue tracks work to do the necessary refactoring to migrate to the new APIs.
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels May 10, 2022
@gopherbot gopherbot added this to the Unreleased milestone May 10, 2022
@findleyr findleyr mentioned this issue May 10, 2022
Closed
@bcmills
Copy link
Contributor

bcmills commented May 11, 2022

FWIW, my stack for the concurrency model is still pending. (I was hoping to make progress on it during the Quiet Week last week, but didn't end up with enough bandwidth.)

@jamalc jamalc modified the milestones: Unreleased, gopls/later May 12, 2022
@bcmills
Copy link
Contributor

bcmills commented Jan 23, 2023

jsonrpc2_v2 should be stable at this point, whereas the old jsonrpc2 is at least a little flaky (#55179). We should do this migration at some point in the not too distant future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/backlog
Development

No branches or pull requests
4 participants
@bcmills @gopherbot @jamalc @findleyr