Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vulndb: figure out operations on the last vulnerable version of a package #52837

Closed
neild opened this issue May 10, 2022 · 1 comment
Closed
Assignees
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Milestone

Comments

@neild
Copy link
Contributor

neild commented May 10, 2022

Some operations on a vulndb report should be performed on a vulnerable version of a package. For example, if we want to verify that the symbols in Report.Symbols exist in the package, we should consult a vulnerable version of the package rather than a fixed one, because those symbols may have been removed as part of the fix.

Since checking every vulnerable version will be prohibitively expensive in most cases, we will usually want to pick a single one. A reasonable choice is probably the last vulnerable version.

Given a module path and a list of vulnerable versions from the report, finding the "last vulnerable version" is something that could be automated, but is also surprisingly tricky. Perhaps we should put an explicit known-vulnerable version in the vulndb report for tooling to operate on.

@gopherbot gopherbot added this to the Unreleased milestone May 10, 2022
@heschi heschi added the NeedsFix The path to resolution is known, but the work has not been done. label May 11, 2022
@neild neild self-assigned this Jul 21, 2022
@neild
Copy link
Contributor Author

neild commented Jul 21, 2022

This was done in https://go.dev/cl/412395, by adding an explicit vulnerable_at field.

@neild neild closed this as completed Jul 21, 2022
@julieqiu julieqiu added the vulncheck or vulndb Issues for the x/vuln or x/vulndb repo label Sep 8, 2022
@golang golang locked and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Projects
Status: No status
Development

No branches or pull requests

4 participants