Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: port to linux/loong64 [freeze exception] #52825

Closed
XiaodongLoong opened this issue May 10, 2022 · 10 comments
Closed

all: port to linux/loong64 [freeze exception] #52825

XiaodongLoong opened this issue May 10, 2022 · 10 comments
Labels
arch-loong64 Issues solely affecting the loongson architecture. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.19

Comments

@XiaodongLoong
Copy link
Contributor

XiaodongLoong commented May 10, 2022 •
edited

I want to request a freeze exception to complete the linux/loong64 port. As far as I know, the feasible reasons are following:

  1. As shown in issue all: port to linux/loong64 #46229, the port status could meet the the requirements for a new port.
  2. The influence of porting to loong64 is limited to loong64 only and it should not block 1.19 release cycle.
  3. The golang/loong64 team has been established with four members. I think we have ability to solve the problems in the future.

Thanks! ❤️

CC @rsc @golang/release
@XiaodongLoong XiaodongLoong mentioned this issue May 10, 2022
Closed
@heschi heschi added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label May 10, 2022
@heschi heschi added this to the Go1.19 milestone May 10, 2022
@dmitshur
Copy link
Contributor

Also CC @golang/runtime.

@rsc
Copy link
Contributor

rsc commented May 10, 2022

How long an exception is needed? We would prefer a time-limited exception. An open-ended exception until the release is probably too risky, even for something that clearly shouldn't affect other ports.

@XiaodongLoong
Copy link
Contributor Author

XiaodongLoong commented May 11, 2022 •
edited

How about two months (in May and June)? I also want to know the thoughts from runtime team @golang/runtime.

@toothrot
Copy link
Contributor

Approved. This work doesn't add risk to anything other than the linux/loong64 port, so it is safe to proceed. Thanks!

@toothrot toothrot added the NeedsFix The path to resolution is known, but the work has not been done. label May 18, 2022
@gopherbot gopherbot removed the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label May 18, 2022
@gopherbot
Copy link

Change https://go.dev/cl/408154 mentions this issue: go.mod: update golang.org/x/sys to latest version

gopherbot pushed a commit to golang/net that referenced this issue May 26, 2022
@tklauser @gopherbot
go.mod: update golang.org/x/sys to latest version
5463443 
This fixes the build on linux/loong64

For golang/go#52825

Change-Id: I7bcf9978c10d884b943e98fec71f74ef8ee56ea7
Reviewed-on: https://go-review.googlesource.com/c/net/+/408154
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Tobias Klauser <tobias.klauser@gmail.com>
Reviewed-by: Damien Neil <dneil@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Damien Neil <dneil@google.com>
@aclements
Copy link
Member

Just doing a mid-June check-in. How is the port looking? I know it's in and enabled at this point (🎉). Is there more work to do before closing this issue (and possibly #46229)?

@xen0n
Copy link
Member

xen0n commented Jun 15, 2022

Hi, at this point I don't think the port has any remaining major issue; the Linux ABI change since the port merge has been addressed, I compiled some services of my day job, and some CLI tools for my daily workflow, and there was no problem running them.

Some work remains (e.g. regabi support) but these can come later in the go1.20 cycle. I personally think this and #46229 could be closed as finished.

@XiaodongLoong
Copy link
Contributor Author

@aclements The loong64 port has been completed, all CLs in stack have been merged.
I checked the all merged CLs, regabi support is a TODO work for CL https://go-review.googlesource.com/c/go/+/367039, I agree with @xen0n, support this feature in the go1.20 cycle.
There are some issues that have a label named arch-loong64, we will try our best to fix them.
I think the current issue and #46229 could be closed.

Thanks!

@abner-chenc
Copy link
Contributor

Thanks all, I support @xen0n and @XiaodongLoong ‘s idea that the issue and #46229 can be closed.

@ianlancetaylor
Copy link
Contributor

Thanks all. We no longer need this freeze exception, so closing.

@XiaodongLoong XiaodongLoong added the arch-loong64 Issues solely affecting the loongson architecture. label Jul 25, 2022
WeiminShang added a commit to WeiminShang/net that referenced this issue Nov 16, 2022
@WeiminShang @gopherbot
go.mod: update golang.org/x/sys to latest version
0687307 
This fixes the build on linux/loong64

For golang/go#52825

Change-Id: I7bcf9978c10d884b943e98fec71f74ef8ee56ea7
Reviewed-on: https://go-review.googlesource.com/c/net/+/408154
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Tobias Klauser <tobias.klauser@gmail.com>
Reviewed-by: Damien Neil <dneil@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Damien Neil <dneil@google.com>
@golang golang locked and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
arch-loong64 Issues solely affecting the loongson architecture. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Release Status & Release Blockers
Status: Done
Milestone
Go1.19
Development

No branches or pull requests
10 participants
@toothrot @rsc @xen0n @dmitshur @aclements @ianlancetaylor @gopherbot @heschi @abner-chenc @XiaodongLoong