-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/go/pointer: failure with Entering directory
and no other output
#52824
Comments
(attn @timothy-king @zpavlinovic) |
The lack of output could possibly be due to an unexpected call to (The |
Does this issue still appear? I was not able to reproduce it locally ( I've tried creating some illustrative examples where
It is possible that the issue appears under certain timing conditions (or that I am missing something obvious). I've also went through callees of Any other suggestions for reproducing this? |
There is only one occurrence so far in the logs. This is probably a nondeterministic failure of some sort, or perhaps a bad failure mode of some subprocess being terminated due to memory exhaustion. |
If any action is needed atm, should we somehow change this from |
The
But it's also entirely possible that the failure was caused by something else in the process. 🤔 Probably the thing to do for now is just wait for clues from any similar failures. |
Strange. I don't see any calls to os.Exit (except indirectly via log.Fatal or similar, which prints an error), and in any case the test driver now detects and reports this mistake. The only calls to t.Fail (which prints no message) are after calls to doOneInput, which maintains the invariant that a false result is never returned without an error being printed. The "Entering directory" message doesn't mean the failure is necessarily in that Test function (as your discussion of Example implicitly acknowledges), but none of the other tests looks suspicious. I think it's "impossible", which suggests an external event killed the process. I don't think the go/pointer package itself has a fault. Closing this for now. Feel free to reopen if it recurs. |
greplogs -l -e '^Entering directory .*\nFAIL\s+golang\.org/x/tools/go/pointer'
2022-05-09T19:54:59-b87ceec-f088f49/linux-amd64-longtest
The text was updated successfully, but these errors were encountered: