Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: invalid metadata after removing recursive import #52729

Closed
findleyr opened this issue May 5, 2022 · 1 comment
Closed

x/tools/gopls: invalid metadata after removing recursive import #52729

findleyr opened this issue May 5, 2022 · 1 comment
Assignees
@findleyr
Labels
FrozenDueToAge gopls/metadata Issues related to metadata loading in gopls gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.9.2

Comments

@findleyr
Copy link
Contributor

findleyr commented May 5, 2022

I observed today while working on go/types: my package was broken due to a trivial recursive import: goimports inserted an import of go/types in methodset.go because I typed types.<...> rather than just <...>. Goimports shouldn't do that, but independently when I removed the import, the go list errors persisted.

Looks like a metadata invalidation bug.
@findleyr findleyr added the gopls/metadata Issues related to metadata loading in gopls label May 5, 2022
@findleyr findleyr added this to the gopls/on-deck milestone May 5, 2022
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels May 5, 2022
@findleyr findleyr added this to Backlog in Gopls Backlog May 10, 2022
@findleyr findleyr removed this from Backlog in Gopls Backlog May 10, 2022
@findleyr findleyr modified the milestones: gopls/later, gopls/v0.9.2 Aug 3, 2022
@findleyr
Copy link
Contributor Author

findleyr commented Aug 3, 2022

Just tried to reproduce, and couldn't. Given that we've rewritten a large chunk of metadata invalidation since this was filed, I think we can close this.

@findleyr findleyr closed this as completed Aug 3, 2022
@findleyr findleyr self-assigned this Aug 8, 2022
@golang golang locked and limited conversation to collaborators Aug 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@findleyr findleyr

Labels
FrozenDueToAge gopls/metadata Issues related to metadata loading in gopls gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.9.2
Development

No branches or pull requests
2 participants
@gopherbot @findleyr