Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: TestDialCancel is not compatible with new macOS ARM64 builders [1.18 backport] #52706

Closed
gopherbot opened this issue May 4, 2022 · 4 comments
Labels
Builders x/build issues (builders, bots, dashboards) CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@gopherbot
Copy link

@bcmills requested issue #52579 to be considered for backport to the next 1.18 minor release.

@gopherbot, please backport to Go 1.17 and 1.18. This test is currently failing on the release branches too.

@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label May 4, 2022
@bcmills bcmills added this to the Go1.18.2 milestone May 4, 2022
@bcmills
Copy link
Contributor

bcmills commented May 4, 2022

(This is a release-blocker via #11811.)

@dmitshur dmitshur added Testing An issue that has been verified to require only test changes, not just a test failure. Builders x/build issues (builders, bots, dashboards) labels May 4, 2022
@dmitshur
Copy link
Contributor

dmitshur commented May 9, 2022

Approving as a test-only fix needed to unblock the release.

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels May 9, 2022
@gopherbot
Copy link
Author

Change https://go.dev/cl/405294 mentions this issue: [release-branch.go1.18] net: skip TestDialCancel on darwin-arm64

@gopherbot
Copy link
Author

Closed by merging b2b4b9e to release-branch.go1.18.

gopherbot pushed a commit that referenced this issue May 9, 2022
We're turning up Macs in a network environment that clashes with this
test. I don't think it's critical to get it working, so skip it.

For #49149.
Fixes #52706.

Change-Id: I925e3ecc5356c4cefd208bdcff3d98021215d0b4
Reviewed-on: https://go-review.googlesource.com/c/go/+/402181
Reviewed-by: Alex Rakoczy <alex@golang.org>
Run-TryBot: Heschi Kreinick <heschi@google.com>
Auto-Submit: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit 06b0a65)
Reviewed-on: https://go-review.googlesource.com/c/go/+/405294
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
@golang golang locked and limited conversation to collaborators May 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Builders x/build issues (builders, bots, dashboards) CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

3 participants