Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: add "v" and "go" prefixes to versions on pkg.go.dev/vuln pages #52684

Closed
julieqiu opened this issue May 3, 2022 · 1 comment
Closed

x/pkgsite: add "v" and "go" prefixes to versions on pkg.go.dev/vuln pages #52684

julieqiu opened this issue May 3, 2022 · 1 comment
Labels
FrozenDueToAge pkgsite
Milestone
pkgsite/unplanned

Comments

@julieqiu
Copy link
Member

julieqiu commented May 3, 2022

It isn't valid SEMVER to prefix versions with "v" or "go" (https://semver.org/#is-v123-a-semantic-version), but it would be nice for readability to have this on the pkg.go.dev/vuln pages.

We should add the relevant prefix when the page is rendered on pkgsite.

/cc @golang/vulndb @golang/pkgsite
@gopherbot gopherbot added this to the pkgsite/unplanned milestone May 3, 2022
@gopherbot
Copy link

Change https://go.dev/cl/409634 mentions this issue: internal/frontend: add version prefixes

@rsc rsc unassigned jba Jun 22, 2022
@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge pkgsite
Projects
None yet
Milestone
pkgsite/unplanned
Development

No branches or pull requests
3 participants
@julieqiu @gopherbot @jba