Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/crypto/internal/wycheproof: TestRsaPss failing on linux-amd64-boringcrypto builder #52670

Closed
bcmills opened this issue May 3, 2022 · 6 comments
Closed

x/crypto/internal/wycheproof: TestRsaPss failing on linux-amd64-boringcrypto builder #52670

bcmills opened this issue May 3, 2022 · 6 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Milestone
Go1.19

Comments

@bcmills
Copy link
Contributor

bcmills commented May 3, 2022 

--- FAIL: TestRsaPss (0.16s)
    rsa_pss_test.go:156: file: rsa_pss_2048_sha512_256_mgf1_28_test.json, tcid: 1, type: valid, opts.SaltLength: 0, comment: "", wanted success: true
    rsa_pss_test.go:156: file: rsa_pss_2048_sha512_256_mgf1_28_test.json, tcid: 2, type: valid, opts.SaltLength: 0, comment: "", wanted success: true
    rsa_pss_test.go:156: file: rsa_pss_2048_sha512_256_mgf1_28_test.json, tcid: 3, type: valid, opts.SaltLength: 0, comment: "", wanted success: true
    rsa_pss_test.go:156: file: rsa_pss_2048_sha512_256_mgf1_28_test.json, tcid: 4, type: valid, opts.SaltLength: 0, comment: "", wanted success: true
    rsa_pss_test.go:156: file: rsa_pss_2048_sha512_256_mgf1_28_test.json, tcid: 5, type: valid, opts.SaltLength: 0, comment: "", wanted success: true
    rsa_pss_test.go:156: file: rsa_pss_2048_sha512_256_mgf1_28_test.json, tcid: 6, type: valid, opts.SaltLength: 0, comment: "", wanted success: true
    rsa_pss_test.go:156: file: rsa_pss_2048_sha512_256_mgf1_28_test.json, tcid: 7, type: valid, opts.SaltLength: 0, comment: "", wanted success: true
    rsa_pss_test.go:156: file: rsa_pss_2048_sha512_256_mgf1_28_test.json, tcid: 13, type: invalid, opts.SaltLength: 0, comment: "s_len changed to 0", wanted success: true
    rsa_pss_test.go:156: file: rsa_pss_2048_sha512_256_mgf1_28_test.json, tcid: 14, type: invalid, opts.SaltLength: 0, comment: "s_len changed to 20", wanted success: true
    rsa_pss_test.go:156: file: rsa_pss_2048_sha512_256_mgf1_28_test.json, tcid: 15, type: invalid, opts.SaltLength: 0, comment: "s_len changed to 32", wanted success: true
    rsa_pss_test.go:156: file: rsa_pss_2048_sha512_256_mgf1_28_test.json, tcid: 16, type: valid, opts.SaltLength: 0, comment: "salt is all 0", wanted success: true
    rsa_pss_test.go:156: file: rsa_pss_2048_sha512_256_mgf1_28_test.json, tcid: 17, type: valid, opts.SaltLength: 0, comment: "salt is all 1", wanted success: true
    rsa_pss_test.go:156: file: rsa_pss_2048_sha512_256_mgf1_28_test.json, tcid: 1, type: valid, opts.SaltLength: 28, comment: "", wanted success: true
    rsa_pss_test.go:156: file: rsa_pss_2048_sha512_256_mgf1_28_test.json, tcid: 2, type: valid, opts.SaltLength: 28, comment: "", wanted success: true
    rsa_pss_test.go:156: file: rsa_pss_2048_sha512_256_mgf1_28_test.json, tcid: 3, type: valid, opts.SaltLength: 28, comment: "", wanted success: true
    rsa_pss_test.go:156: file: rsa_pss_2048_sha512_256_mgf1_28_test.json, tcid: 4, type: valid, opts.SaltLength: 28, comment: "", wanted success: true
    rsa_pss_test.go:156: file: rsa_pss_2048_sha512_256_mgf1_28_test.json, tcid: 5, type: valid, opts.SaltLength: 28, comment: "", wanted success: true
    rsa_pss_test.go:156: file: rsa_pss_2048_sha512_256_mgf1_28_test.json, tcid: 6, type: valid, opts.SaltLength: 28, comment: "", wanted success: true
    rsa_pss_test.go:156: file: rsa_pss_2048_sha512_256_mgf1_28_test.json, tcid: 7, type: valid, opts.SaltLength: 28, comment: "", wanted success: true
    rsa_pss_test.go:156: file: rsa_pss_2048_sha512_256_mgf1_28_test.json, tcid: 16, type: valid, opts.SaltLength: 28, comment: "salt is all 0", wanted success: true
    rsa_pss_test.go:156: file: rsa_pss_2048_sha512_256_mgf1_28_test.json, tcid: 17, type: valid, opts.SaltLength: 28, comment: "salt is all 1", wanted success: true
    rsa_pss_test.go:156: file: rsa_pss_2048_sha512_256_mgf1_32_test.json, tcid: 1, type: valid, opts.SaltLength: 0, comment: "", wanted success: true
    rsa_pss_test.go:156: file: rsa_pss_2048_sha512_256_mgf1_32_test.json, tcid: 2, type: valid, opts.SaltLength: 0, comment: "", wanted success: true
    rsa_pss_test.go:156: file: rsa_pss_2048_sha512_256_mgf1_32_test.json, tcid: 3, type: valid, opts.SaltLength: 0, comment: "", wanted success: true
    rsa_pss_test.go:156: file: rsa_pss_2048_sha512_256_mgf1_32_test.json, tcid: 4, type: valid, opts.SaltLength: 0, comment: "", wanted success: true
    rsa_pss_test.go:156: file: rsa_pss_2048_sha512_256_mgf1_32_test.json, tcid: 5, type: valid, opts.SaltLength: 0, comment: "", wanted success: true
    rsa_pss_test.go:156: file: rsa_pss_2048_sha512_256_mgf1_32_test.json, tcid: 6, type: valid, opts.SaltLength: 0, comment: "", wanted success: true
    rsa_pss_test.go:156: file: rsa_pss_2048_sha512_256_mgf1_32_test.json, tcid: 7, type: valid, opts.SaltLength: 0, comment: "", wanted success: true
    rsa_pss_test.go:156: file: rsa_pss_2048_sha512_256_mgf1_32_test.json, tcid: 13, type: invalid, opts.SaltLength: 0, comment: "s_len changed to 0", wanted success: true
    rsa_pss_test.go:156: file: rsa_pss_2048_sha512_256_mgf1_32_test.json, tcid: 14, type: invalid, opts.SaltLength: 0, comment: "s_len changed to 20", wanted success: true
    rsa_pss_test.go:156: file: rsa_pss_2048_sha512_256_mgf1_32_test.json, tcid: 15, type: valid, opts.SaltLength: 0, comment: "salt is all 0", wanted success: true
    rsa_pss_test.go:156: file: rsa_pss_2048_sha512_256_mgf1_32_test.json, tcid: 16, type: valid, opts.SaltLength: 0, comment: "salt is all 1", wanted success: true
    rsa_pss_test.go:156: file: rsa_pss_2048_sha512_256_mgf1_32_test.json, tcid: 1, type: valid, opts.SaltLength: 32, comment: "", wanted success: true
    rsa_pss_test.go:156: file: rsa_pss_2048_sha512_256_mgf1_32_test.json, tcid: 2, type: valid, opts.SaltLength: 32, comment: "", wanted success: true
    rsa_pss_test.go:156: file: rsa_pss_2048_sha512_256_mgf1_32_test.json, tcid: 3, type: valid, opts.SaltLength: 32, comment: "", wanted success: true
    rsa_pss_test.go:156: file: rsa_pss_2048_sha512_256_mgf1_32_test.json, tcid: 4, type: valid, opts.SaltLength: 32, comment: "", wanted success: true
    rsa_pss_test.go:156: file: rsa_pss_2048_sha512_256_mgf1_32_test.json, tcid: 5, type: valid, opts.SaltLength: 32, comment: "", wanted success: true
    rsa_pss_test.go:156: file: rsa_pss_2048_sha512_256_mgf1_32_test.json, tcid: 6, type: valid, opts.SaltLength: 32, comment: "", wanted success: true
    rsa_pss_test.go:156: file: rsa_pss_2048_sha512_256_mgf1_32_test.json, tcid: 7, type: valid, opts.SaltLength: 32, comment: "", wanted success: true
    rsa_pss_test.go:156: file: rsa_pss_2048_sha512_256_mgf1_32_test.json, tcid: 15, type: valid, opts.SaltLength: 32, comment: "salt is all 0", wanted success: true
    rsa_pss_test.go:156: file: rsa_pss_2048_sha512_256_mgf1_32_test.json, tcid: 16, type: valid, opts.SaltLength: 32, comment: "salt is all 1", wanted success: true
FAIL
FAIL	golang.org/x/crypto/internal/wycheproof	6.062s

greplogs -l -e 'FAIL: TestRsaPss' --since=2022-01-01
2022-05-03T14:14:31-eb4f295-b75e492/linux-amd64-boringcrypto
2022-05-03T12:34:17-eb4f295-a41e37f/linux-amd64-boringcrypto
2022-05-03T05:42:48-eb4f295-0668e3c/linux-amd64-boringcrypto
2022-05-02T22:12:49-eb4f295-f771edd/linux-amd64-boringcrypto

(attn @golang/security, @rsc)
@gopherbot gopherbot added this to the Unreleased milestone May 3, 2022
@bcmills
Copy link
Contributor Author

bcmills commented May 3, 2022

This is a release-blocker via #11811.

@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages) labels May 3, 2022
@bcmills bcmills modified the milestones: Unreleased, Go1.19 May 3, 2022
@bcmills
Copy link
Contributor Author

bcmills commented May 3, 2022

(This builder is new for #51940.)

@bcmills bcmills mentioned this issue May 3, 2022
Closed
@bcmills bcmills removed the Soon This needs to be done soon. (regressions, serious bugs, outages) label May 4, 2022
@rolandshoemaker
Copy link
Member

boringcrypto doesn't support the truncated SHA-512 hashes (as far as I can tell), so the SHA-512/224 and SHA-512/256 will always fail. Not sure if there is a clear way to determine whether boringcrypto has been enabled outside of the standard library in order to skip these?

@heschi
Copy link
Contributor

heschi commented May 11, 2022

@bcmills says this might have been fixed?

@bcmills
Copy link
Contributor Author

bcmills commented May 11, 2022 •
edited

Fixed by CL 404654, but the issue didn't get tagged in it because it's cross-repo.

(@rolandshoemaker, you might need to run git codereview hooks in your clone of the repo to install the hook that rewrites cross-repo references.)

@bcmills bcmills closed this as completed May 11, 2022
@rolandshoemaker
Copy link
Member

I swear I always think I've fixed this and somehow I've never actually fixed it.

@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Projects
None yet
Milestone
Go1.19
Development

No branches or pull requests
4 participants
@rolandshoemaker @bcmills @gopherbot @heschi