Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/coordinator: some x-repo builders not allowed from TRY=line #52667

Closed
bcmills opened this issue May 3, 2022 · 6 comments
Closed

x/build/cmd/coordinator: some x-repo builders not allowed from TRY=line #52667

bcmills opened this issue May 3, 2022 · 6 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release Team
Milestone
Unreleased

Comments

@bcmills
Copy link
Contributor

bcmills commented May 3, 2022 •
edited

https://go.dev/wiki/SlowBots currently says:

For the main Go repository, the terms after TRY= can also be:

  • x/repo, where repo is one of the golang.org/x repositories whose tests should be executed. This runs a default builder for the given repo (linux-amd64 as of writing).
  • x/repo@builder, where repo is as above, and builder is a builder name from the builder list. This runs the specified builder for the given repo. For example, x/sys@linux-arm64-aws.

I attempted to use that functionality in https://go-review.googlesource.com/c/go/+/403694/1#message-384468da277d8d207745408ee312e594834c0c3b, with the line

TRY=longtest,windows-amd64-longtest,x/sys@longtest,x/sys@windows-amd64-longtest

I expected that that would run the usual TryBots, plus longtest and windows-amd64-longtest SlowBots for the go repo, plus longtest and windows-amd64-longtest SlowBots for the x/sys repo.

However, the x/sys SlowBots were not included in that run, and the Coordinator didn't reply with any kind of error message for the TRY= line.
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label May 3, 2022
@gopherbot gopherbot added this to the Unreleased milestone May 3, 2022
@bcmills
Copy link
Contributor Author

bcmills commented May 3, 2022 •
edited

I tried again in https://go-review.googlesource.com/c/go/+/403694/1#message-e384c689409e2701273d9ea9e87a132aee29c93b with just

TRY=x/sys@windows-amd64-longtest

but that doesn't seem to have worked either. This is making it difficult to verify the fix for #52666.

@findleyr
Copy link
Contributor

findleyr commented May 3, 2022

The reason for this is likely that windows-amd64-longtest is not a TryBot, which is currently required:
https://cs.opensource.google/go/x/build/+/master:cmd/coordinator/coordinator.go;l=1312;drc=993f2c6f22a69963d73f42c2712c601bff8c3939

Unfortunately, it is only surfaced in logs, and not in a message back to the CL.

This actually came up in chat recently: I think we don't actually need to impose this restriction.

@gopherbot
Copy link

Change https://go.dev/cl/403675 mentions this issue: cmd/coordinator: relax the set of x-repo builders allowed as slowbots

@findleyr findleyr changed the title x/build/cmd/coordinator: x repos not parsed from TRY=line x/build/cmd/coordinator: some x-repo builders not allowed from TRY=line May 3, 2022
@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label May 3, 2022
@findleyr
Copy link
Contributor

findleyr commented May 3, 2022

Reopening until the coordinator is deployed.

As a follow-up, I'll try to include more details about parsing failures / invalid slowbots in the starting message.

@findleyr findleyr reopened this May 3, 2022
@dmitshur
Copy link
Contributor

dmitshur commented May 3, 2022

I'll redeploy coordinator with this change after https://farmer.golang.org/#remote reaches 0 active gomote sessions.

@dmitshur dmitshur added this to In Progress in Go Release Team May 3, 2022
@dmitshur
Copy link
Contributor

dmitshur commented May 3, 2022

The fix is deployed; thanks Bryan and Rob.

@dmitshur dmitshur closed this as completed May 3, 2022
Go Release Team automation moved this from In Progress to Done May 3, 2022
@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Go Release Team
Done
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@dmitshur @bcmills @gopherbot @findleyr