Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/analysis/passes/errorsas: Test failing with "unexpected diagnostic" in Go 1.18+ (i.e., when typeparams.Enabled is true) #52613

Closed
dmitshur opened this issue Apr 28, 2022 · 1 comment
Closed

x/tools/go/analysis/passes/errorsas: Test failing with "unexpected diagnostic" in Go 1.18+ (i.e., when typeparams.Enabled is true) #52613

dmitshur opened this issue Apr 28, 2022 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

Test is failing as of CL 339889:

--- FAIL: Test (1.26s)
    analysistest.go:453: typeparams/typeparams.go:31:2: unexpected diagnostic: second argument to errors.As should not be *error
FAIL
FAIL	golang.org/x/tools/go/analysis/passes/errorsas	1.291s

(Source: https://build.golang.org/?repo=golang.org%2fx%2ftools)
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) labels Apr 28, 2022
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Apr 28, 2022
@gopherbot gopherbot added this to the Unreleased milestone Apr 28, 2022
@dmitshur dmitshur changed the title x/tools/go/analysis/passes/errorsas: Test failing due to "unexpected diagnostic" x/tools/go/analysis/passes/errorsas: Test failing with "unexpected diagnostic" Apr 29, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/403034 mentions this issue: go/analysis/passes/errorsas: update testdata for new warning

@dmitshur dmitshur pinned this issue Apr 29, 2022
@dmitshur dmitshur changed the title x/tools/go/analysis/passes/errorsas: Test failing with "unexpected diagnostic" x/tools/go/analysis/passes/errorsas: Test failing with "unexpected diagnostic" in Go 1.18+ (i.e., when typeparams.Enabled is true) Apr 29, 2022
@dmitshur dmitshur self-assigned this Apr 29, 2022
@dmitshur dmitshur unpinned this issue Apr 29, 2022
@rsc rsc unassigned neild and dmitshur Jun 22, 2022
@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@neild @dmitshur @gopherbot