Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/ssa: tracking turning ssa.InstantiateGenerics mode on #52504

Closed
14 tasks done
timothy-king opened this issue Apr 22, 2022 · 1 comment
Closed
14 tasks done

x/tools/go/ssa: tracking turning ssa.InstantiateGenerics mode on #52504

timothy-king opened this issue Apr 22, 2022 · 1 comment
Labels
Analysis Issues related to static analysis (vet, x/tools/go/analysis) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@timothy-king
Copy link
Contributor

timothy-king commented Apr 22, 2022 •
edited by zpavlinovic

This is a tracking bug for whether to enable ssa.InstantiateGenerics as a part of the ssa.BuilderMode for ssa construction in x/tools.

Part of the larger effort of #48525.

Subdirectories that need to be checked:

  • ./cmd/callgraph
  • ./cmd/ssadump
  • ./go/analysis/passes/buildssa
  • ./go/analysis/passes/nilness
  • ./go/analysis/passes/unusedwrite
  • ./go/callgraph
  • ./go/callgraph/cha
  • ./go/callgraph/rta
  • ./go/callgraph/static
  • ./go/callgraph/vta
  • ./go/pointer
  • ./go/ssa
  • ./go/ssa/interp
  • ./go/ssa/ssautil

Checking should cover tests as well.

Edit: Considering ./cmd/guru addressed for the purpose of tracking as there are no action items for it at the moment. For now progress here is blocked on the larger decision about whether guru will support generics. That needs to be decided first.
@timothy-king timothy-king added the Analysis Issues related to static analysis (vet, x/tools/go/analysis) label Apr 22, 2022
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Apr 22, 2022
@gopherbot gopherbot added this to the Unreleased milestone Apr 22, 2022
@cagedmantis cagedmantis added the NeedsFix The path to resolution is known, but the work has not been done. label Apr 27, 2022
@gopherbot
Copy link

Change https://go.dev/cl/402276 mentions this issue: pointer: Adds unit tests for pointer with type parameters.

gopherbot pushed a commit to golang/tools that referenced this issue May 2, 2022
@timothy-king
pointer: Adds unit tests for pointer with type parameters.
7c895e0 
Adds tests for pointer that test pointer flows through type instantiations.

Updates pointer_test.go to support one probe per instantiation. This is due to there being one copy of a Function per instantiation.

Updates golang/go#48525
Updates golang/go#52504

Change-Id: Ia750cd37ddf1aaf55342ff8464f12e96e7e1030f
Reviewed-on: https://go-review.googlesource.com/c/tools/+/402276
Reviewed-by: Zvonimir Pavlinovic <zpavlinovic@google.com>
Reviewed-by: Guodong Li <guodongli@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
Run-TryBot: Guodong Li <guodongli@google.com>
@timothy-king timothy-king mentioned this issue May 17, 2022
Closed
@golang golang locked and limited conversation to collaborators May 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Analysis Issues related to static analysis (vet, x/tools/go/analysis) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@cagedmantis @timothy-king @gopherbot