Skip to content

go/types: add gc arch size for loong64 #52495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
findleyr opened this issue Apr 22, 2022 · 1 comment
Closed

go/types: add gc arch size for loong64 #52495

findleyr opened this issue Apr 22, 2022 · 1 comment
Labels
FrozenDueToAge
Milestone
Go1.19

Comments

@findleyr
Copy link
Member

Recently, we've noticed that gopls has started logging "unknown architecture loong64", due to this log statement:
https://cs.opensource.google/go/x/tools/+/master:go/analysis/passes/asmdecl/asmdecl.go;l=129;drc=884ffcdf166f9ee4133a974a6f996d551c8a8bbb

This is because go/types is missing loong64 here:
https://cs.opensource.google/go/go/+/master:src/go/types/sizes.go;l=167;drc=19309779ac5e2f5a2fd3cbb34421dafb2855ac21

This is straightforward to fix, and should be done for 1.19. Opening this tracking issue for searchability.

CC @griesemer
@findleyr findleyr added this to the Go1.19 milestone Apr 22, 2022
@findleyr findleyr self-assigned this Apr 22, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/401576 mentions this issue: go/types, types2: add loong64 to gcArchSizes

@dgunay dgunay mentioned this issue May 8, 2022
Closed
@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.19
Development

No branches or pull requests
2 participants
@gopherbot @findleyr