Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/talks/present: line numbers for .code and .play segments #5248

Closed
Sajmani opened this issue Apr 9, 2013 · 4 comments
Closed

x/talks/present: line numbers for .code and .play segments #5248

Sajmani opened this issue Apr 9, 2013 · 4 comments

Comments

@Sajmani
Copy link
Contributor

Sajmani commented Apr 9, 2013

I'm preparing a talk using present that demonstrates the output of panics and the
deadlock detector.  The stack traces show line numbers like:
goroutine 1 [running]:
main.main()
    /tmp/compile5.go:20 +0x11f

But it's difficult to cross-reference these against the code displayed on the slide. 
Displaying line numbers for .code and .play segments would address this issue (the
filename doesn't matter).  The key point here is that the displayed line numbers must
match those in the file delivered to the compiler (e.g., omitting any "OMIT"
comments), not the lines in the segment selected by the .code or .play START/STOP
regexps.
@rsc
Copy link
Contributor

rsc commented Nov 27, 2013

Comment 1:

Labels changed: added go1.3maybe.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 2:

Labels changed: added release-none, removed go1.3maybe.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 3:

Labels changed: added repo-talks.

@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@rsc rsc changed the title go.talks/present: line numbers for .code and .play segments x/talks/present: line numbers for .code and .play segments Apr 14, 2015
@rsc rsc modified the milestones: Unreleased, Unplanned Apr 14, 2015
@rsc rsc removed the repo-talks label Apr 14, 2015
@gopherbot
Copy link
Contributor

CL https://golang.org/cl/20311 mentions this issue.

jjneely pushed a commit to jjneely/present that referenced this issue Nov 4, 2016

Verified

This commit was signed with the committer’s verified signature.
myitcv Paul Jolly
Line numbers match line numbers from the included file,
not the lines in the segment selected by the
.code or .play START/STOP regexps.

Fixes golang/go#5248

Change-Id: I374e7b665e98db5032446ae49e6fae00d9d2b975
Reviewed-on: https://go-review.googlesource.com/20311
Reviewed-by: Andrew Gerrand <adg@golang.org>
@golang golang locked and limited conversation to collaborators Mar 13, 2017
@rsc rsc unassigned adg Jun 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants