Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: cmd/go TestScript/cover_pkgall_runtime broken by CL 388477 #52472

Closed
prattmic opened this issue Apr 21, 2022 · 6 comments
Closed

runtime: cmd/go TestScript/cover_pkgall_runtime broken by CL 388477 #52472

prattmic opened this issue Apr 21, 2022 · 6 comments
Assignees
@prattmic
Labels
FrozenDueToAge
Milestone
Go1.19

Comments

@prattmic
Copy link
Member

prattmic commented Apr 21, 2022 •
edited

https://go.dev/cl/388477 causes failures in cmd/go TestScript/cover_pkgall_runtime on linux-amd64-longtest.

https://build.golang.org/log/b204a00cd3a2301edb04e903019d3e47aa0c545f

I will be sending revert CLs shortly

cc @bcmills
@prattmic prattmic added release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages) labels Apr 21, 2022
@prattmic prattmic added this to the Go1.19 milestone Apr 21, 2022
@prattmic prattmic self-assigned this Apr 21, 2022
@gopherbot
Copy link

Change https://go.dev/cl/401636 mentions this issue: Revert "syscall: define Syscall in terms of RawSyscall on linux"

@gopherbot
Copy link

Change https://go.dev/cl/401634 mentions this issue: Revert "runtime/internal/syscall: use ABIInternal for Syscall6 on amd64"

@gopherbot
Copy link

Change https://go.dev/cl/401635 mentions this issue: Revert "syscall: define Syscall6 in terms of RawSyscall6 on linux"

@prattmic prattmic changed the title runtime: TestScript/cover_pkgall_runtime broken by CL 388477 runtime: cmd/go TestScript/cover_pkgall_runtime broken by CL 388477 Apr 21, 2022
gopherbot pushed a commit that referenced this issue Apr 21, 2022
@prattmic @gopherbot
Revert "runtime/internal/syscall: use ABIInternal for Syscall6 on amd64"
3475343 
This reverts CL 401096. Grandparent CL 388477 breaks cmd/go
TestScript/cover_pkgall_runtime.

For #51087.
For #52472.

Change-Id: Ie82fe5f50975f66eb91fb0d01cd8bbbd0265eb4e
Reviewed-on: https://go-review.googlesource.com/c/go/+/401634
Run-TryBot: Michael Pratt <mpratt@google.com>
Auto-Submit: Michael Pratt <mpratt@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
gopherbot pushed a commit that referenced this issue Apr 21, 2022
@prattmic @gopherbot
Revert "syscall: define Syscall6 in terms of RawSyscall6 on linux"
d35ec0b 
This reverts CL 388478. Parent CL 388477 breaks cmd/go
TestScript/cover_pkgall_runtime.

For #51087.
For #52472.

Change-Id: Id5d5a4e138792cf130ecdcc6b996c8102d142a7e
Reviewed-on: https://go-review.googlesource.com/c/go/+/401635
Run-TryBot: Michael Pratt <mpratt@google.com>
Auto-Submit: Michael Pratt <mpratt@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
gopherbot pushed a commit that referenced this issue Apr 21, 2022
@prattmic @gopherbot
Revert "syscall: define Syscall in terms of RawSyscall on linux"
aac1d3a 
This reverts CL 388477, which breaks cmd/go
TestScript/cover_pkgall_runtime.

For #51087.
For #52472.

Change-Id: Id58af419a889281f15df2471c58fece011fcffbc
Reviewed-on: https://go-review.googlesource.com/c/go/+/401636
Run-TryBot: Michael Pratt <mpratt@google.com>
Auto-Submit: Michael Pratt <mpratt@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@prattmic prattmic removed release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages) labels Apr 21, 2022
@gopherbot
Copy link

Change https://go.dev/cl/401654 mentions this issue: syscall: define Syscall in terms of RawSyscall on linux

@gopherbot
Copy link

Change https://go.dev/cl/401656 mentions this issue: runtime/internal/syscall: use ABIInternal for Syscall6 on amd64

@gopherbot
Copy link

Change https://go.dev/cl/401655 mentions this issue: syscall: define Syscall6 in terms of RawSyscall6 on linux

gopherbot pushed a commit that referenced this issue Apr 22, 2022
@prattmic
syscall: define Syscall6 in terms of RawSyscall6 on linux
808d40d 
This is an exact copy of CL 388478 after fixing #52472 in CL 401654.

For #51087
For #52472

Change-Id: I6c6bd7ddcab1512c682e6b44f61c7bcde97f5c58
Reviewed-on: https://go-review.googlesource.com/c/go/+/401655
Run-TryBot: Michael Pratt <mpratt@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
gopherbot pushed a commit that referenced this issue Apr 22, 2022
@prattmic
runtime/internal/syscall: use ABIInternal for Syscall6 on amd64
3e73241 
This is an exact copy of CL 401096 after fixing #52472 in CL 401654.

For #51087
For #52472

Change-Id: Ib3c914949a15517aacdca2d72e69e1c7b217e430
Reviewed-on: https://go-review.googlesource.com/c/go/+/401656
Run-TryBot: Michael Pratt <mpratt@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
@prattmic prattmic self-assigned this Jun 24, 2022
@golang golang locked and limited conversation to collaborators Jun 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@prattmic prattmic

Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.19
Development

No branches or pull requests
2 participants
@prattmic @gopherbot