Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/crypto/ssh/terminal: mark functions as Deprecated? #52469

Closed
kevinburkesegment opened this issue Apr 21, 2022 · 2 comments
Closed

x/crypto/ssh/terminal: mark functions as Deprecated? #52469

kevinburkesegment opened this issue Apr 21, 2022 · 2 comments
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@kevinburkesegment
Copy link

kevinburkesegment commented Apr 21, 2022 •
edited

Currently the functions in x/crypto/ssh/terminal just call their equivalents in golang.org/x/term.

Should we mark those functions as Deprecated? This will e.g. trigger people who are using staticcheck to import the new package, which is smaller and more focused than the x/crypto module.

Happy to do this, just wanted to ask first in the name of Chesterton's Fence and all that.
@gopherbot gopherbot added this to the Unreleased milestone Apr 21, 2022
@ianlancetaylor
Copy link
Contributor

SGTM

@ianlancetaylor ianlancetaylor added help wanted NeedsFix The path to resolution is known, but the work has not been done. labels Apr 21, 2022
@kevinburkesegment
Copy link
Author

Sorry; the mistake is on my end. We were using an outdated version of the x/crypto project before the "Deprecation" notice, but I was looking at a newer source code version in my browser.

The updated package has a "Deprecated" tag on it, that's correctly picked up by build tools. Closing.

@golang golang locked and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@ianlancetaylor @gopherbot @kevinburkesegment