Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: go run -mod=mod [files...] does not update go.mod and go.sum [1.18 backport] #52468

Closed
gopherbot opened this issue Apr 21, 2022 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go modules
Milestone

Comments

@gopherbot
Copy link

@bcmills requested issue #52331 to be considered for backport to the next 1.18 minor release.

@gopherbot, please backport to Go 1.18. This is a regression in the behavior of go run, and results in non-reproducible commands.

@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Apr 21, 2022
@gopherbot gopherbot added this to the Go1.18.2 milestone Apr 21, 2022
@bcmills bcmills added modules CherryPickApproved Used during the release process for point releases labels Apr 21, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Apr 21, 2022
@dmitshur dmitshur added the GoCommand cmd/go label Apr 21, 2022
@bcmills bcmills self-assigned this May 4, 2022
@gopherbot
Copy link
Author

Change https://go.dev/cl/404094 mentions this issue: [release-branch.go1.18] cmd/go: write changes to go.mod and go.sum after loading the command-line-arguments package

@gopherbot
Copy link
Author

Closed by merging 2d6881b to release-branch.go1.18.

gopherbot pushed a commit that referenced this issue May 9, 2022
…ter loading the command-line-arguments package

This entrypoint was missed in CL 349600, and the behavior happened not
to be covered by existing tests.

Updates #52331.
Fixes #52468.

Change-Id: Iccf12e8e633215abe4bfa1c3ca2fe3a8391b5ba5
Reviewed-on: https://go-review.googlesource.com/c/go/+/401536
Run-TryBot: Bryan Mills <bcmills@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Michael Matloob <matloob@golang.org>
(cherry picked from commit cf69725)
Reviewed-on: https://go-review.googlesource.com/c/go/+/404094
Reviewed-by: David Chase <drchase@google.com>
@rsc rsc unassigned bcmills Jun 22, 2022
@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go modules
Projects
None yet
Development

No branches or pull requests

3 participants