Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http/httptest: race in Close [1.17 backport] #52455

Closed
neild opened this issue Apr 20, 2022 · 2 comments
Closed

net/http/httptest: race in Close [1.17 backport] #52455

neild opened this issue Apr 20, 2022 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.17.10

Comments

@neild
Copy link
Contributor

neild commented Apr 20, 2022

Consider #51799 for backport to the next 1.17 minor release.

1.18 backport is #51897.
@neild neild added the CherryPickCandidate Used during the release process for point releases label Apr 20, 2022
@neild neild added this to the Go1.17.10 milestone Apr 20, 2022
@gopherbot
Copy link

Change https://go.dev/cl/401318 mentions this issue: [release-branch.go1.17] net/http/httptest: fix race in Server.Close

@dr2chase dr2chase added the CherryPickApproved Used during the release process for point releases label May 4, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label May 4, 2022
gopherbot pushed a commit that referenced this issue May 9, 2022
@maisem @heschi
[release-branch.go1.17] net/http/httptest: fix race in Server.Close
4c5acd4 
When run with race detector the test fails without the fix.

For #51799
Fixes #52455

Change-Id: I273adb6d3a2b1e0d606b9c27ab4c6a9aa4aa8064
GitHub-Last-Rev: a5ddd14
GitHub-Pull-Request: #51805
Reviewed-on: https://go-review.googlesource.com/c/go/+/393974
Reviewed-by: Damien Neil <dneil@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Trust: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
(cherry picked from commit 1d19cea)
Reviewed-on: https://go-review.googlesource.com/c/go/+/401318
Reviewed-by: David Chase <drchase@google.com>
@gopherbot
Copy link

Closed by merging 4c5acd4 to release-branch.go1.17.

@knz knz mentioned this issue May 25, 2022
Closed
@golang golang locked and limited conversation to collaborators May 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.17.10
Development

No branches or pull requests
3 participants
@neild @dr2chase @gopherbot