You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello,
Another day I talked with a workmate and we perceived that's package has an interface validate only method Error() maybe we should validate likewise Is/As/Unwrap.
@seankhliao is not exactly equal to the issue you commented on but is similar. I saw other issues similar to it so I did understand why you closed it. Thanks a lot
Adding methods to an existing interface definition is not backwards compatible. There are essentially no circumstances under which new methods will be added directly to error. It would break a lot of existing code.
Hello,
Another day I talked with a workmate and we perceived that's package has an interface validate only method
Error()
maybe we should validate likewiseIs/As/Unwrap
.See lines below:
Unwrap
go/src/errors/wrap.go
Lines 15 to 17 in 0e08b02
Is
go/src/errors/wrap.go
Lines 50 to 52 in 0e08b02
As
go/src/errors/wrap.go
Lines 96 to 98 in 0e08b02
Interface error
go/src/builtin/builtin.go
Lines 280 to 282 in 0e08b02
I will propose two ways then we need to choose only one.
Does this make sense?
see ya Gophers
The text was updated successfully, but these errors were encountered: