Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: the .Deps field is used to determine whether test-variant packages have import cycles #52443

Open
matloob opened this issue Apr 19, 2022 · 0 comments
Labels
GoCommand cmd/go NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@matloob
Copy link
Contributor

matloob commented Apr 19, 2022

Currently cmd/go uses the Deps field to determine cycles on test variant packages. This requires us to call collectDeps and examine the entire set of transitive dependencies for each test variant package even if we're not doing a go list command that requires presenting the transitive set of dependencies for each package in the output.

We should probably find another way to determine whether test-variant packages have import cycles.

cc @bcmills

@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. GoCommand cmd/go labels Apr 20, 2022
@bcmills bcmills modified the milestones: Gccgo, Backlog Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GoCommand cmd/go NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

2 participants