Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: negative line numbers in hashmap traceback #5243

Closed
alberts opened this issue Apr 8, 2013 · 3 comments
Closed

runtime: negative line numbers in hashmap traceback #5243

alberts opened this issue Apr 8, 2013 · 3 comments
Labels
FrozenDueToAge

Comments

@alberts
Copy link
Contributor

alberts commented Apr 8, 2013 

https://golang.org/issue/5239?c=3

I also noticed these negative line numbers. Worth a separate bug?

[fp=0x7f3c68f5cd70] evacuate(0xb17da0, 0xc3d8aa06c0, 0xac68b6)
/build/go/go/src/pkg/runtime/hashmap.c:-343 +0xbd
[fp=0x7f3c68f5cd98] grow_work(0xb17da0, 0xc3d8aa06c0, 0xac68b6)
/build/go/go/src/pkg/runtime/hashmap.c:-223 +0x58
@minux
Copy link
Member

minux commented Apr 10, 2013

Comment 1:

Labels changed: added priority-later, removed priority-triage.

Status changed to Accepted.

@remyoudompheng
Copy link
Contributor

Comment 2:

My own tool (github.com/remyoudompheng/go-misc/debug/objdump) shows correct line numbers
in runtime.a.
I am tempted to say the problem is in runtime/symtab.c:^dosrcline
// walk symtab accumulating path names for use by pc/ln table.
// don't need the full generality of the z entry history stack because                 
// there are no includes in go (and only sensible includes in our c);                  
// assume code only appear in top-level files.                                         
static void
dosrcline(Sym *sym)

@rsc
Copy link
Contributor

rsc commented Jul 30, 2013

Comment 3:

This was almost certainly caused by the #included C source in that file, and it is
almost certainly fixed by my line number reimplementation. If you see this again please
open a new bug.

Status changed to Fixed.

@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rsc @minux @remyoudompheng @alberts @gopherbot