Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: TestServerRequestContextCancel_ConnClose timeouts on slower builders #52414

Closed
bcmills opened this issue Apr 18, 2022 · 2 comments
Closed

net/http: TestServerRequestContextCancel_ConnClose timeouts on slower builders #52414

bcmills opened this issue Apr 18, 2022 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.19

Comments

@bcmills
Copy link
Contributor

bcmills commented Apr 18, 2022 

--- FAIL: TestServerRequestContextCancel_ConnClose (4.92s)
    serve_test.go:4897: timeout waiting to see ServeHTTP get called
2022/04/13 07:12:39 http: TLS handshake error from 127.0.0.1:51046: EOF
2022/04/13 07:12:39 http: TLS handshake error from 127.0.0.1:51048: EOF
2022/04/13 07:12:39 http: TLS handshake error from 127.0.0.1:51052: EOF
2022/04/13 07:12:39 http: TLS handshake error from 127.0.0.1:51058: EOF
FAIL
FAIL	net/http	66.927s

greplogs --dashboard -md -l -e 'FAIL: TestServerRequestContextCancel_ConnClose .*\n .*timeout waiting to see ServeHTTP get called'

2022-04-12T23:50:58-65558a4/linux-riscv64-jsing
2021-03-24T21:51:22-29ed12d/darwin-amd64-race
2020-10-01T19:13:03-5756b35/darwin-amd64-race
2019-11-08T23:22:06-11da2b2/solaris-amd64-oraclerel
@bcmills
Copy link
Contributor Author

bcmills commented Apr 18, 2022

Looks like another hard-coded arbitrary timeout in the test. 😩

The problem does not appear to be platform-dependent, and the fix should be easy, so marking as release-blocker for Go 1.19.

@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. release-blocker labels Apr 18, 2022
@bcmills bcmills self-assigned this Apr 18, 2022
@bcmills bcmills added this to the Go1.19 milestone Apr 18, 2022
@gopherbot
Copy link

Change https://go.dev/cl/400816 mentions this issue: net/http: eliminate arbitrary timeouts in TestServerRequestContextCancel_ConnClose

@rsc rsc unassigned bcmills Jun 22, 2022
@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.19
Development

No branches or pull requests
2 participants
@bcmills @gopherbot