Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

time: TestTruncateRound failure on windows-amd64-race #52409

Closed
bcmills opened this issue Apr 18, 2022 · 4 comments
Closed

time: TestTruncateRound failure on windows-amd64-race #52409

bcmills opened this issue Apr 18, 2022 · 4 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Milestone
Go1.19

Comments

@bcmills
Copy link
Contributor

bcmills commented Apr 18, 2022 

--- FAIL: TestTruncateRound (0.08s)
    time_test.go:327: Time.Round(292277024745-03-22T05:19:12.046916062Z, 1911567h18m9.24972109s) = 292277024812-12-10 14:07:35.54851097 +0000 UTC, want 292277024845-12-31T06:48:18.54851097Z
        -9223372033153436463953083938 round 6881642289249721090 =
        -9223372031016300760451489030 want
        -9223372029973133517451489030
FAIL
FAIL	time	2.300s

greplogs --dashboard -md -l -e 'FAIL: TestTruncateRound'

2022-04-15T23:25:46-e398266/windows-amd64-race
@bcmills bcmills added this to the Go1.19 milestone Apr 18, 2022
@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. and removed OS-Windows labels Apr 18, 2022
@bcmills
Copy link
Contributor Author

bcmills commented Apr 18, 2022

Since windows/amd64 is a first-class port, marking as release-blocker for triage.

It's not obvious to me whether this failure was for one of the hard-coded inputs or the randomly-generated ones.

@rsc rsc self-assigned this Apr 25, 2022
@gopherbot
Copy link

Change https://go.dev/cl/402177 mentions this issue: time: fix quickcheck test to avoid wraparounds

@rsc
Copy link
Contributor

rsc commented Apr 25, 2022

Looks like that was a 1-in-300,000,000 guess on the part of the windows-amd64-race builder. The short builder was doing 1000, so really 1-in-300,000. And then there were four of those tests that could have failed, so 1-in-75,000. It seems like we should have seen this a few times already given the number of trybot and CL checks we run. Anyway, it should be fixed by the pending CL.

@bcmills
Copy link
Contributor Author

bcmills commented Apr 25, 2022

Oh, neat! I think that overflow is exactly #20678. 😅

@rsc rsc removed their assignment Jun 22, 2022
@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Projects
None yet
Milestone
Go1.19
Development

No branches or pull requests
3 participants
@rsc @bcmills @gopherbot