x/build/cmd/release: Windows zip/installer includes unnecessary pkg/tool/windows_amd64/api.exe
#52335
Labels
Builders
x/build issues (builders, bots, dashboards)
FrozenDueToAge
NeedsFix
The path to resolution is known, but the work has not been done.
OS-Windows
Milestone
What version of Go are you using (
go version
)?https://go.dev/dl/go1.18.1.windows-amd64.zip
What did you expect to see?
I don't think
pkg/tool/windows_amd64/api.exe
should be included.pkg/tool/linux_amd64/api
isn't included in the Linux tar.gz.The logic behind leaving out
api
is explained in cmd/release/release.go#L506-L510 and #13030:What did you see instead?
pkg/tool/windows_amd64/api.exe
is in the zip. It also shows up after using the msi installer.I think
cmd/release
is probably just missing the code to remove the.exe
because it was originally written with Linux in mind. I spotted this when I was comparing a Go build I did vs. the official Go build--this didn't break something I was working on. It seems pretty minor. (The file is only 5 MB.)The text was updated successfully, but these errors were encountered: