Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: DetectContentType: add audio/amr signature #52334

Closed
OneOfOne opened this issue Apr 13, 2022 · 5 comments
Closed

net/http: DetectContentType: add audio/amr signature #52334

OneOfOne opened this issue Apr 13, 2022 · 5 comments
Labels
FeatureRequest FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@OneOfOne
Copy link
Contributor

The signature for that audio file type is missing.
@OneOfOne
Copy link
Contributor Author

https://go-review.googlesource.com/c/go/+/400174

@gopherbot
Copy link

Change https://go.dev/cl/400174 mentions this issue: net/http: DetectContentType: add audio/amr signature

@neild
Copy link
Contributor

neild commented Apr 13, 2022

https://mimesniff.spec.whatwg.org/#matching-an-audio-or-video-type-pattern doesn't include a pattern for audio/amr.

@OneOfOne
Copy link
Contributor Author

@neild I'd like to argue that it's a popular enough format in the mobile world specially with older headsets that it warrants support.

@neild
Copy link
Contributor

neild commented Apr 14, 2022

We don't really want to be in the business of making judgments about what is popular enough or not. DetectContentType is documented as following the WHATWG algorithm; the way to add a new type is to convince WHATWG to add it.

@dmitshur dmitshur added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. FeatureRequest labels Apr 14, 2022
@dmitshur dmitshur added this to the Backlog milestone Apr 14, 2022
@seankhliao seankhliao closed this as not planned Won't fix, can't repro, duplicate, stale Jul 29, 2022
@golang golang locked and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FeatureRequest FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@neild @OneOfOne @dmitshur @gopherbot @seankhliao