Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/x509: CreateCertificate should omit extensions if there aren't any #52319

Closed
rolandshoemaker opened this issue Apr 13, 2022 · 1 comment
Closed

crypto/x509: CreateCertificate should omit extensions if there aren't any #52319

rolandshoemaker opened this issue Apr 13, 2022 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.

Comments

@rolandshoemaker
Copy link
Member

When creating a certificate, if there are no extensions, the extensions SEQUENCE should be omitted, per RFC 5280 (SEQUENCE SIZE (1..MAX)). Fix is relatively simple.

Example of a cert that has an empty extensions SEQUENCE (generated using https://go.dev/play/p/QK11453Bcu3.)
@rolandshoemaker rolandshoemaker added the NeedsFix The path to resolution is known, but the work has not been done. label Apr 13, 2022
@rolandshoemaker rolandshoemaker self-assigned this Apr 13, 2022
@gopherbot
Copy link

Change https://go.dev/cl/399827 mentions this issue: crypto/x509: omit empty extensions SEQUENCE

@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rolandshoemaker @gopherbot