Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync: TestWaitGroupMisuse2 is flaky [1.17 backport] #52306

Closed
gopherbot opened this issue Apr 12, 2022 · 2 comments
Closed

sync: TestWaitGroupMisuse2 is flaky [1.17 backport] #52306

gopherbot opened this issue Apr 12, 2022 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.17.10

Comments

@gopherbot
Copy link

@dmitshur requested issue #38163 to be considered for backport to the next 1.17 minor release.

@gopherbot Please backport to Go 1.17 as a test-only fix. The TestWaitGroupMisuse2 test had a flaky failure during the 1.17.9 release, which requires tests to be re-run and slows the process down.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Apr 12, 2022
@gopherbot gopherbot mentioned this issue Apr 12, 2022
Closed
@gopherbot gopherbot added this to the Go1.17.9 milestone Apr 12, 2022
@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label Apr 12, 2022
@gopherbot
Copy link
Author

Change https://go.dev/cl/399821 mentions this issue: [release-branch.go1.17] sync: remove TestWaitGroupMisuse2 and TestWaitGroupMisuse3

@dmitshur dmitshur modified the milestones: Go1.17.9, Go1.17.10 Apr 12, 2022
@heschi heschi added the CherryPickApproved Used during the release process for point releases label Apr 20, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Apr 20, 2022
@gopherbot
Copy link
Author

Closed by merging 0fdca72 to release-branch.go1.17.

gopherbot pushed a commit that referenced this issue May 2, 2022
@neild @dmitshur
[release-branch.go1.17] sync: remove TestWaitGroupMisuse2 and TestWai…
0fdca72 
…tGroupMisuse3

These tests are inherently nondeterministic: They exercise a racy
code path for up to one million iterations, and require that an
error occur at least once.

TestWaitGroupMisuse2 in particular is an ongoing source of trybot
flakiness.

Updates #38163.
Fixes #52306.

Change-Id: Ibbbda2c998c915333487ad262d3df6829de01c2b
Reviewed-on: https://go-review.googlesource.com/c/go/+/340249
Trust: Damien Neil <dneil@google.com>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Damien Neil <dneil@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitry Vyukov <dvyukov@google.com>
(cherry picked from commit 011fd00)
Reviewed-on: https://go-review.googlesource.com/c/go/+/399821
Run-TryBot: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
@golang golang locked and limited conversation to collaborators May 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.17.10
Development

No branches or pull requests
3 participants
@dmitshur @gopherbot @heschi