Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: compiler crash with "Dictionary should have already been generated" [1.18 backport] #52286

Closed
gopherbot opened this issue Apr 11, 2022 · 4 comments
Closed

cmd/compile: compiler crash with "Dictionary should have already been generated" [1.18 backport] #52286

gopherbot opened this issue Apr 11, 2022 · 4 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.18.3

Comments

@gopherbot
Copy link

@ianlancetaylor requested issue #52279 to be considered for backport to the next 1.18 minor release.

@gopherbot Please open a backport to 1.18

This looks like a compiler crash on valid code.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Apr 11, 2022
@gopherbot gopherbot mentioned this issue Apr 11, 2022
Closed
@gopherbot gopherbot added this to the Go1.18.1 milestone Apr 11, 2022
@dmitshur dmitshur modified the milestones: Go1.18.1, Go1.18.2 Apr 12, 2022
@heschi heschi modified the milestones: Go1.18.2, Go1.18.3 May 10, 2022
@mdempsky
Copy link
Member

Reminder for backporting that // rundir needs to become // rundir -G=3.

@gopherbot
Copy link
Author

Change https://go.dev/cl/405543 mentions this issue: cmd/compile: be sure to export types mentioned in f.i.g. method signature

@gopherbot
Copy link
Author

Closed by merging cf5fa2b to release-branch.go1.18.

gopherbot pushed a commit that referenced this issue May 17, 2022
@dr2chase
cmd/compile: be sure to export types mentioned in f.i.g. method signa…
cf5fa2b 
…ture

When a fully instantiated generic method is exported, be sure to also
export the types in its signature.

Updates #52279.
Fixes #52286.

Change-Id: Icc6bca05b01f914cf67faaf1bf184eaa5484f521
Reviewed-on: https://go-review.googlesource.com/c/go/+/405118
Run-TryBot: David Chase <drchase@google.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit 1284cc2)
Reviewed-on: https://go-review.googlesource.com/c/go/+/405543
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
@toothrot toothrot added the CherryPickApproved Used during the release process for point releases label May 25, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label May 25, 2022
@toothrot
Copy link
Contributor

Approved. This is a serious issue with no workaround.

@golang golang locked and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.18.3
Development

No branches or pull requests
5 participants
@toothrot @mdempsky @dmitshur @gopherbot @heschi