Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gopls/internal/regtest: use a real file system notifier #52284

Open
findleyr opened this issue Apr 11, 2022 · 0 comments
Open

gopls/internal/regtest: use a real file system notifier #52284

findleyr opened this issue Apr 11, 2022 · 0 comments
Labels
gopls Issues related to the Go language server, gopls. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@findleyr
Copy link
Contributor

It looks like several gopls testing flakes may be related to inaccurate file system notifications (e.g. #51930).

Historically, the gopls regtests had executed in the x/tools module, and so could not import cross platform libraries for filesystem notifications (e.g. https://github.com/fsnotify/fsnotify). To work around this, file watching is 'faked' via polling.

The regtests are now in x/tools/gopls, and we should consider replacing this polling with an actual notification library. This would theoretically reduce flakes and improve accuracy.

@findleyr findleyr added this to the gopls/on-deck milestone Apr 11, 2022
@gopherbot gopherbot added the gopls Issues related to the Go language server, gopls. label Apr 11, 2022
@findleyr findleyr added Testing An issue that has been verified to require only test changes, not just a test failure. and removed gopls/testing labels May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Issues related to the Go language server, gopls. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

2 participants