Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/mod/zip: TestUnzipSizeLimitsSpecial/size_is_a_lie broken as of CL 366854 #52283

Closed
bcmills opened this issue Apr 11, 2022 · 1 comment
Closed

x/mod/zip: TestUnzipSizeLimitsSpecial/size_is_a_lie broken as of CL 366854 #52283

bcmills opened this issue Apr 11, 2022 · 1 comment
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages) Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.19

Comments

@bcmills
Copy link
Contributor

bcmills commented Apr 11, 2022

CL 366854 (fix for #49791) changed the failure mode of archive/zip for files with mismatched sizes.
That fix seems appropriate, but the test needs to be updated to allow for the new failure mode. (It was previously checking what you could consider to be an x/mod/zip workaround for #49791.)

This is a release-blocker for Go 1.19 via #11811, but the test should be fixed well before that to avoid adding noise in the builders.

(attn @mengzhuo @odeke-em; CC @golang/release)
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages) labels Apr 11, 2022
@gopherbot gopherbot added this to the Unreleased milestone Apr 11, 2022
@bcmills bcmills modified the milestones: Unreleased, Go1.19 Apr 11, 2022
@gopherbot
Copy link

Change https://go.dev/cl/399774 mentions this issue: zip: update TestUnzipSizeLimitsSpecial for CL 366854

@golang golang locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages) Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.19
Development

No branches or pull requests
2 participants
@bcmills @gopherbot