Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/types, types2: go generic assert compile escape [1.18 backport] #52244

Closed
gopherbot opened this issue Apr 8, 2022 · 2 comments
Closed

go/types, types2: go generic assert compile escape [1.18 backport] #52244

gopherbot opened this issue Apr 8, 2022 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.18.2

Comments

@gopherbot
Copy link

@ianlancetaylor requested issue #52228 to be considered for backport to the next 1.18 minor release.

@gopherbot Please open backport to 1.18

This is valid code that is being compiled incorrectly.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Apr 8, 2022
@gopherbot gopherbot mentioned this issue Apr 8, 2022
Closed
@gopherbot gopherbot added this to the Go1.18.1 milestone Apr 8, 2022
@dmitshur dmitshur modified the milestones: Go1.18.1, Go1.18.2 Apr 12, 2022
@gopherbot
Copy link
Author

Change https://go.dev/cl/399974 mentions this issue: [release-branch.go1.18] cmd/compile: always write fun[0] in incomplete itab

@heschi heschi added the CherryPickApproved Used during the release process for point releases label Apr 20, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Apr 20, 2022
gopherbot pushed a commit that referenced this issue May 9, 2022
@randall77 @heschi
[release-branch.go1.18] cmd/compile: always write fun[0] in incomplet…
2375a68 
…e itab

runtime.getitab need filled fun[0] to identify whether
implemented the interface.

Fixes #51738
Fixes #52244

Change-Id: I0173b98f4e1b45e3a0183a5b60229d289140d1e6
Reviewed-on: https://go-review.googlesource.com/c/go/+/399058
Reviewed-by: Keith Randall <khr@golang.org>
Run-TryBot: Keith Randall <khr@golang.org>
Auto-Submit: Keith Randall <khr@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: David Chase <drchase@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/399974
Reviewed-by: Austin Clements <austin@google.com>
@gopherbot
Copy link
Author

Closed by merging 2375a68 to release-branch.go1.18.

@golang golang locked and limited conversation to collaborators May 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.18.2
Development

No branches or pull requests
3 participants
@dmitshur @gopherbot @heschi