Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd: longtest builders broken by direct update of vendored code #52231

Closed
heschi opened this issue Apr 8, 2022 · 1 comment
Closed

cmd: longtest builders broken by direct update of vendored code #52231

heschi opened this issue Apr 8, 2022 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages)
Milestone
Go1.19

Comments

@heschi
Copy link
Contributor

heschi commented Apr 8, 2022

https://go.dev/cl/398734 updated code in cmd/vendor directly, causing the longtest builders to fail, e.g. https://build.golang.org/log/3f04ea467a69b08ab9c67f4a297c61f91d7a6385.

--- FAIL: TestAllDependencies (13.09s)
    --- FAIL: TestAllDependencies/cmd(thorough) (1.63s)
        moddeps_test.go:221: Module cmd in /workdir/go/src/cmd is not tidy (-want +got):
            
            diff --recursive --unified /workdir/tmp/TestAllDependencies1732877436/002/src/cmd/vendor/golang.org/x/arch/ppc64/ppc64asm/tables.go /workdir/go/src/cmd/vendor/golang.org/x/arch/ppc64/ppc64asm/tables.go
            --- /workdir/tmp/TestAllDependencies1732877436/002/src/cmd/vendor/golang.org/x/arch/ppc64/ppc64asm/tables.go	2022-04-08 14:19:51.650021642 +0000
            +++ /workdir/go/src/cmd/vendor/golang.org/x/arch/ppc64/ppc64asm/tables.go	2022-04-08 13:44:41.000000000 +0000
            @@ -4037,9 +4037,9 @@
             		[6]*argField{ap_VecReg_6_10, ap_VecReg_16_20}},
             	{XSADDSP, 0xfc0007f800000000, 0xf000000000000000, 0x0, // VSX Scalar Add Single-Precision XX3-form (xsaddsp XT,XA,XB)
             		[6]*argField{ap_VecSReg_31_31_6_10, ap_VecSReg_29_29_11_15, ap_VecSReg_30_30_16_20}},
            -	{XSCVDPSPN, 0xfc0007fc00000000, 0xf000042c00000000, 0x1f000000000000, // VSX Scalar Convert Scalar Single-Precision to Vector Single-Precision format Non-signalling XX2-form (xscvdpspn XT,XB)
            +	{XSCVDPSPN, 0xfc0007fc00000000, 0xf000042c00000000, 0x1f000000000000, // VSX Scalar Convert Scalar Single-Precision to Vector Single-Precision format Non-signaling XX2-form (xscvdpspn XT,XB)
             		[6]*argField{ap_VecSReg_31_31_6_10, ap_VecSReg_30_30_16_20}},
            -	{XSCVSPDPN, 0xfc0007fc00000000, 0xf000052c00000000, 0x1f000000000000, // VSX Scalar Convert Single-Precision to Double-Precision format Non-signalling XX2-form (xscvspdpn XT,XB)
            +	{XSCVSPDPN, 0xfc0007fc00000000, 0xf000052c00000000, 0x1f000000000000, // VSX Scalar Convert Single-Precision to Double-Precision format Non-signaling XX2-form (xscvspdpn XT,XB)
             		[6]*argField{ap_VecSReg_31_31_6_10, ap_VecSReg_30_30_16_20}},
             	{XSCVSXDSP, 0xfc0007fc00000000, 0xf00004e000000000, 0x1f000000000000, // VSX Scalar Convert with round Signed Doubleword to Single-Precision format XX2-form (xscvsxdsp XT,XB)
             		[6]*argField{ap_VecSReg_31_31_6_10, ap_VecSReg_30_30_16_20}},
            
            To fix it, run:
            
            $ cd /workdir/go/src/cmd
            $ go mod tidy                               # to remove extraneous dependencies
            $ go mod vendor                             # to vendor dependencies
            $ go generate -run=bundle cmd/...               # to regenerate bundled packages
            
            (If module cmd is definitely tidy, this could mean
            there's a problem in the go or bundle command.)

cc @mvdan @ianlancetaylor
@heschi heschi added NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages) labels Apr 8, 2022
@heschi heschi added this to the Go1.19 milestone Apr 8, 2022
@gopherbot
Copy link

Change https://go.dev/cl/399154 mentions this issue: cmd/vendor: revert vendored code mistakenly modified in CL 398734

@golang golang locked and limited conversation to collaborators Apr 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages)
Projects
None yet
Milestone
Go1.19
Development

No branches or pull requests
2 participants
@gopherbot @heschi