Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: release version v0.8.3 #52213

Closed
8 tasks done
findleyr opened this issue Apr 7, 2022 · 3 comments
Closed
8 tasks done

x/tools/gopls: release version v0.8.3 #52213

findleyr opened this issue Apr 7, 2022 · 3 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.8.3

Comments

@findleyr
Copy link
Contributor

findleyr commented Apr 7, 2022 •
edited

We plan to release gopls@v0.8.3 next week to pick up support for staticcheck@v0.3.0, which supports generics (see also #52159).

Tentative plan: tag a prerelease today and let it soak until next week.

  • merge master into gopls-release-branch.0.8
  • update hard-coded version
  • update go.mod/go.sum (remove x/tools replace, update x/tools version)
  • tag gopls/v0.8.3-pre.1
  • update Github milestone
  • write release notes
  • smoke test features
  • tag gopls/v0.8.3
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Apr 7, 2022
@gopherbot gopherbot added this to the Unreleased milestone Apr 7, 2022
@gopherbot
Copy link

Change https://go.dev/cl/398814 mentions this issue: all: merge master (7f10777) into gopls-release-branch.0.8

@gopherbot
Copy link

Change https://go.dev/cl/398815 mentions this issue: internal/lsp/debug: update hard-coded version for v0.8.3

gopherbot pushed a commit to golang/tools that referenced this issue Apr 7, 2022
@findleyr
all: merge master (7f10777) into gopls-release-branch.0.8
08c7723 
Also update gopls/go.mod to replace x/tools.

For golang/go#52213

Conflicts:

- gopls/go.mod
- gopls/go.sum

Merge List:

+ 2022-04-07 7f10777 gopls/internal/regtest/modfile: temporarily skip TestSumUpdateFixesDiagnostics
+ 2022-04-07 7cc24c2 gopls: upgrade staticcheck to v0.3.0
+ 2022-04-07 1f763df internal/lsp: add semantic tokens for arrows in declarations
+ 2022-04-06 b3e0236 go/ssa: Track created functions in the builder.
+ 2022-04-06 6731659 go/ssa: adds position info to implicit field selection instructions
+ 2022-04-06 74cea6e internal/imports: ignore some line directives
+ 2022-04-05 37acb39 internal/lsp: run vulncheck in specified dir
+ 2022-04-04 4077921 all: fix spelling
+ 2022-04-04 ff66cbe internal/lsp: remove unused parameters from moduleAtVersion
+ 2022-04-04 7d125fe cmd/callgraph: expand windows/arm64 skip to the whole platform
+ 2022-04-01 153e30b internal/lsp/lsprpc: only propagate explicit GOWORK when using remote
+ 2022-03-31 cda13e2 internal/lsp: fix incorrect line and start of semantic tokens
+ 2022-03-31 41787c4 gopls: run go mod tidy -compat=1.16 to fix the 1.16 build
+ 2022-03-31 b9a4807 internal/gopathwalk: remove unnecessary call to os.Lstat
+ 2022-03-30 8e193c2 go/ssa: removes conversion of index value in Index and IndexAddr to int
+ 2022-03-30 9d8009b go/analysis: validate report if analyzer.Run is empty
+ 2022-03-29 761e51f go/ssa/interp: Adds reflect.DeepEqual model for interp testing

Change-Id: I2d9255f835fada04e125aa3bb16571a02a50d6d7
gopherbot pushed a commit to golang/tools that referenced this issue Apr 7, 2022
@findleyr
internal/lsp/debug: update hard-coded version for v0.8.3
91bcfb1 
For golang/go#52213

Change-Id: I6fe0608d896bd84a4fd510f009ed961d457472a5
Reviewed-on: https://go-review.googlesource.com/c/tools/+/398815
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
Trust: Suzy Mueller <suzmue@golang.org>
@gopherbot
Copy link

Change https://go.dev/cl/398816 mentions this issue: gopls: update go.mod for v0.8.3

gopherbot pushed a commit to golang/tools that referenced this issue Apr 7, 2022
@findleyr
gopls: update go.mod for v0.8.3
961a87f 
Remove the replace directive and update x/tools.

For golang/go#52213

Change-Id: I0c49b68968c69c97194a7b6ee063a6eed0624074
Reviewed-on: https://go-review.googlesource.com/c/tools/+/398816
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Peter Weinberger <pjw@google.com>
@suzmue suzmue modified the milestones: Unreleased, gopls/v0.8.3 Apr 8, 2022
@golang golang locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.8.3
Development

No branches or pull requests
3 participants
@suzmue @gopherbot @findleyr