Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: upgrade to staticcheck@v0.3.0 #52159

Closed
findleyr opened this issue Apr 5, 2022 · 2 comments
Closed

x/tools/gopls: upgrade to staticcheck@v0.3.0 #52159

findleyr opened this issue Apr 5, 2022 · 2 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.8.3

Comments

@findleyr
Copy link
Contributor

findleyr commented Apr 5, 2022

We should release a new version of gopls to pick up the upgraded staticcheck dependency.

Among other things, this means we will only support staticcheck with Go 1.17+ (dominikh/go-tools#1238), so we should improve our UX for users that have enabled staticcheck at Go 1.16. We should warn that the staticcheck option is unsupported at this Go version, similar to how we warn for deprecated or unknown configuration options.
@findleyr findleyr added this to the gopls/v0.8.3 milestone Apr 5, 2022
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Apr 5, 2022
@gopherbot
Copy link

Change https://go.dev/cl/396974 mentions this issue: gopls: upgrade staticcheck to v0.3.0

@findleyr findleyr mentioned this issue Apr 7, 2022
Closed
8 tasks
@gopherbot
Copy link

Change https://go.dev/cl/399914 mentions this issue: gopls/internal/regtest: add a test for using staticcheck with generics

gopherbot pushed a commit to golang/tools that referenced this issue May 11, 2022
@findleyr
gopls/internal/regtest: add a test for using staticcheck with generics
728485f 
For golang/go#52159

Change-Id: I08120331b7f5c9eb06feac0d0eeb76a9a7b629df
Reviewed-on: https://go-review.googlesource.com/c/tools/+/399914
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Dylan Le <dungtuanle@google.com>
@golang golang locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.8.3
Development

No branches or pull requests
2 participants
@gopherbot @findleyr