Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: go work use -r panics when given a directory that does not exist [1.18 backport] #52140

Closed
gopherbot opened this issue Apr 4, 2022 · 2 comments
Closed

cmd/go: go work use -r panics when given a directory that does not exist [1.18 backport] #52140

gopherbot opened this issue Apr 4, 2022 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go
Milestone
Go1.18.1

Comments

@gopherbot
Copy link

@bcmills requested issue #51841 to be considered for backport to the next 1.18 minor release.

@gopherbot, please backport to Go 1.18. This is a user-facing panic in a feature introduced in Go 1.18.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Apr 4, 2022
@gopherbot gopherbot mentioned this issue Apr 4, 2022
Closed
@gopherbot gopherbot added this to the Go1.18.1 milestone Apr 4, 2022
@bcmills bcmills added the CherryPickApproved Used during the release process for point releases label Apr 4, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Apr 4, 2022
@gopherbot
Copy link
Author

Change https://go.dev/cl/397995 mentions this issue: [release-branch.go1.18] cmd/go: prevent panic in go work use

@gopherbot
Copy link
Author

Closed by merging f92bfa4 to release-branch.go1.18.

gopherbot pushed a commit that referenced this issue Apr 5, 2022
@notfilippo @cherrymui
[release-branch.go1.18] cmd/go: prevent panic in go work use
f92bfa4 
Check if paths passed as arguments are existing directories.

Fixes #52140
Updates #51841

Change-Id: Icfd148627e6f2c4651d6f923a37d413e68c67f6c
GitHub-Last-Rev: 77fffa7
GitHub-Pull-Request: #51845
Reviewed-on: https://go-review.googlesource.com/c/go/+/394154
Trust: Bryan Mills <bcmills@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Trust: Emmanuel Odeke <emmanuel@orijtech.com>
Run-TryBot: Emmanuel Odeke <emmanuel@orijtech.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-on: https://go-review.googlesource.com/c/go/+/397995
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
@cherrymui cherrymui added the GoCommand cmd/go label Apr 6, 2022
@golang golang locked and limited conversation to collaborators Apr 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go
Projects
None yet
Milestone
Go1.18.1
Development

No branches or pull requests
3 participants
@bcmills @gopherbot @cherrymui