Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/types, cmd/compile: type set overlapping implementation for interface types might be not correct [1.18 backport] #52119

Closed
gopherbot opened this issue Apr 2, 2022 · 3 comments
Closed

go/types, cmd/compile: type set overlapping implementation for interface types might be not correct [1.18 backport] #52119

gopherbot opened this issue Apr 2, 2022 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.18.1

Comments

@gopherbot
Copy link

@griesemer requested issue #51607 to be considered for backport to the next 1.18 minor release.

@gopherbot please backport to 1.18, this bug leads to confusing and misleading errors, and the fix is straight-forward.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Apr 2, 2022
@gopherbot gopherbot mentioned this issue Apr 2, 2022
Closed
@gopherbot gopherbot added this to the Go1.18.1 milestone Apr 2, 2022
@gopherbot
Copy link
Author

Change https://go.dev/cl/398154 mentions this issue: [release-branch.go1.18] go/types, types2: fix overlap test for union termlist

@cherrymui cherrymui changed the title cmd/go: type set overlapping implementation for interface types might be not correct [1.18 backport] go/types, cmd/compile: type set overlapping implementation for interface types might be not correct [1.18 backport] Apr 5, 2022
@cherrymui
Copy link
Member

Approved for backport.

@cherrymui cherrymui added CherryPickApproved Used during the release process for point releases NeedsFix The path to resolution is known, but the work has not been done. and removed CherryPickCandidate Used during the release process for point releases NeedsFix The path to resolution is known, but the work has not been done. labels Apr 6, 2022
@gopherbot
Copy link
Author

Closed by merging 2097b2d to release-branch.go1.18.

gopherbot pushed a commit that referenced this issue Apr 6, 2022
@griesemer @cherrymui
[release-branch.go1.18] go/types, types2: fix overlap test for union …
2097b2d 
…termlist

Per the spec, "the type sets of all non-interface terms must be
pairwise disjoint (the pairwise intersection of the type sets must
be empty)" in a union.

For the overlap test, the existing implementation casually mixed
syntactic union terms (which may have interface type) with type set
terms (which are normalized/expanded and must not have interface
type). As a consequence, in some cases the overlap test failed.

This change skips terms with interface types in the overlap test.

For this cherry-pick, also rename the files ending in issue51607.go
to issue51607.go2 because the 1.18 branch requires tests containing
generic features to end in .go2.

Fixes #52119.

Change-Id: I8ae9953db31f0a0428389c6a45a6696aa2450219
Reviewed-on: https://go-review.googlesource.com/c/go/+/397695
Trust: Robert Griesemer <gri@golang.org>
Run-TryBot: Robert Griesemer <gri@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/398154
@golang golang locked and limited conversation to collaborators Apr 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.18.1
Development

No branches or pull requests
2 participants
@gopherbot @cherrymui