Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/net/http2: add DialTLSContext to Transport #52114

Closed
Dreamacro opened this issue Apr 2, 2022 · 6 comments
Closed

x/net/http2: add DialTLSContext to Transport #52114

Dreamacro opened this issue Apr 2, 2022 · 6 comments

Comments

@Dreamacro
Copy link

Dreamacro commented Apr 2, 2022

net.Transport contains DialContext, but http2.Transport only contains DialTLS, so a similar DialTLSContext has been added to make http.Transport support context.

What's changed:

https://github.com/golang/net/blob/8e4df14915a2b0bef8fb1a2d5f67f1bcedc6ab31/http2/transport.go#L66-L88

This proposal only adds a new API, so there is no breaking change.

ref:
golang/net#123
https://go-review.googlesource.com/c/net/+/377114

@gopherbot gopherbot added this to the Proposal milestone Apr 2, 2022
@ianlancetaylor
Copy link
Contributor

CC @neild @bradfitz

@ianlancetaylor ianlancetaylor added this to Incoming in Proposals (old) Apr 6, 2022
@rsc
Copy link
Contributor

rsc commented Apr 13, 2022

It seems like we clearly need DialTLSContext given that it's already in http.Transport.

@rsc
Copy link
Contributor

rsc commented Apr 13, 2022

Based on the discussion above, this proposal seems like a likely accept.
— rsc for the proposal review group

@rsc rsc moved this from Incoming to Likely Accept in Proposals (old) Apr 13, 2022
@rsc rsc moved this from Likely Accept to Accepted in Proposals (old) May 4, 2022
@rsc
Copy link
Contributor

rsc commented May 4, 2022

No change in consensus, so accepted. 🎉
This issue now tracks the work of implementing the proposal.
— rsc for the proposal review group

@rsc rsc changed the title proposal: x/net/http2: add DialTLSContext to Transport x/net/http2: add DialTLSContext to Transport May 4, 2022
@rsc rsc modified the milestones: Proposal, Backlog May 4, 2022
@francislavoie
Copy link

francislavoie commented May 5, 2022

FYI #50392 is a duplicate (rather, was written first, but the PR and this issue were written after without linking to it)

@gopherbot
Copy link

Change https://go.dev/cl/377114 mentions this issue: http2: add DialTLSContext to Transport

@dmitshur dmitshur modified the milestones: Backlog, Unreleased Aug 24, 2022
WeiminShang added a commit to WeiminShang/net that referenced this issue Nov 16, 2022
Fixes golang/go#52114

Change-Id: Ibc0ba6b401bb39ea89f88796d55fbf781596140e
GitHub-Last-Rev: 488673bebeca2cc9d79328cc348ac1014096b697
GitHub-Pull-Request: golang/net#123
Reviewed-on: https://go-review.googlesource.com/c/net/+/377114
Reviewed-by: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
Run-TryBot: Ian Lance Taylor <iant@google.com>
@golang golang locked and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

6 participants