Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/types, types2: improve API for setting type parameter constraints in importers #52104

Open
findleyr opened this issue Apr 1, 2022 · 4 comments
Open

go/types, types2: improve API for setting type parameter constraints in importers #52104

findleyr opened this issue Apr 1, 2022 · 4 comments
Assignees
@griesemer
Labels
early-in-cycle A change that should be done early in the 3 month dev cycle. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Go1.23

Comments

@findleyr
Copy link
Contributor

findleyr commented Apr 1, 2022

As we saw in #51219, the fact that SetConstraint eagerly computes the constraint type set makes the API awkward to use for importers.

We should investigate if this API restriction can be removed or improved.

CC @griesemer
@findleyr findleyr added this to the Go1.19 milestone Apr 1, 2022
@cherrymui cherrymui added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 5, 2022
@ianlancetaylor
Copy link
Contributor

@findleyr What is the current status here? This issue is currently in the 1.19 milestone. Should it move to 1.20? To Backlog? Thanks.

@findleyr
Copy link
Contributor Author

Let's bump to 1.20.

@findleyr findleyr modified the milestones: Go1.19, Go1.20 Jun 24, 2022
@findleyr findleyr modified the milestones: Go1.20, Go1.21 Nov 10, 2022
@gopherbot gopherbot modified the milestones: Go1.21, Go1.22 Aug 8, 2023
@griesemer griesemer self-assigned this Dec 13, 2023
@griesemer griesemer modified the milestones: Go1.22, Go1.23 Dec 13, 2023
@griesemer griesemer added the early-in-cycle A change that should be done early in the 3 month dev cycle. label Dec 13, 2023
@gopherbot
Copy link

This issue is currently labeled as early-in-cycle for Go 1.23.
That time is now, so a friendly reminder to look at it again.

@griesemer
Copy link
Contributor

@findleyr Anything to be done here at this point? Let's decide and then do or close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@griesemer griesemer

Labels
early-in-cycle A change that should be done early in the 3 month dev cycle. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Release Status & Release Blockers
Status: No status
Milestone
Go1.23
Development

No branches or pull requests
5 participants
@ianlancetaylor @griesemer @gopherbot @cherrymui @findleyr