Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/x509: TestPlatformVerifier is failing on windows-amd64-longtest #52094

Closed
heschi opened this issue Apr 1, 2022 · 9 comments
Closed

crypto/x509: TestPlatformVerifier is failing on windows-amd64-longtest #52094

heschi opened this issue Apr 1, 2022 · 9 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages)
Milestone
Go1.19

Comments

@heschi
Copy link
Contributor

heschi commented Apr 1, 2022

https://build.golang.org/log/296b04ad40e69dc38abad33a8d6ee7ffcb03014c

--- FAIL: TestPlatformVerifier (0.19s)
    root_windows_test.go:77: tls connection failed: dial tcp: lookup wrong.host.badssl.com: getaddrinfow: This is usually a temporary error during hostname resolution and means that the local server did not receive a response from an authoritative server.

No idea what's going wrong, I can resolve the host just fine from my home network but not from my Google workstation. This is a release blocker because the release runs the Windows long tests.
@heschi heschi added NeedsFix The path to resolution is known, but the work has not been done. release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages) labels Apr 1, 2022
@heschi
Copy link
Contributor Author

heschi commented Apr 1, 2022

cc @FiloSottile @rolandshoemaker

@heschi
Copy link
Contributor Author

heschi commented Apr 1, 2022

cc @golang/release

@hopehook
Copy link
Member

hopehook commented Apr 1, 2022 •
edited

I can not resolve the host of badssl.com, is it matter？

chromium/badssl.com#500

@dmitshur dmitshur added this to the Go1.19 milestone Apr 1, 2022
@bcmills
Copy link
Contributor

bcmills commented Apr 1, 2022

This is a release blocker because the release runs the Windows long tests.

It's not just that. We rely heavily on the windows-amd64-longtest builder for testing numerous changes, since most of the Go team isn't developing natively on Windows machines day-to-day.

@gopherbot
Copy link

Change https://go.dev/cl/397478 mentions this issue: crypto/x509: skip getaddrinfow errors for "wrong.host.badssl.com"

@heschi
Copy link
Contributor Author

heschi commented Apr 1, 2022

It looks like badssl.com is completely gone. It's a google project, ish... https://github.com/chromium/badssl.com. Let's see what I can find out internally.

@rolandshoemaker
Copy link
Member

It's back up, looks like the DNS was just funky for a while.

@heschi
Copy link
Contributor Author

heschi commented Apr 1, 2022

Indeed. Not sure how I missed chromium/badssl.com#500.

@heschi heschi closed this as completed Apr 1, 2022
gopherbot pushed a commit that referenced this issue Apr 1, 2022
crypto/x509: skip WSATRY_AGAIN errors when dialing badssl.com subdomains
df89f2b 
(Temporarily, until the root cause of the test failure can be
diagnosed and fixed properly.)

For #52094

Change-Id: Iec69e162159f3f0a93135f742aac97cf82c1d96c
Reviewed-on: https://go-review.googlesource.com/c/go/+/397478
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@gopherbot
Copy link

Change https://go.dev/cl/397594 mentions this issue: [release-branch.go1.18] crypto/x509: skip WSATRY_AGAIN errors when dialing badssl.com subdomains

@rolandshoemaker rolandshoemaker mentioned this issue Apr 1, 2022
Open
gopherbot pushed a commit that referenced this issue Apr 1, 2022
@heschi
[release-branch.go1.18] crypto/x509: skip WSATRY_AGAIN errors when di…
32ff9b5 
…aling badssl.com subdomains

(Temporarily, until the root cause of the test failure can be
diagnosed and fixed properly.)

For #52094

Change-Id: Iec69e162159f3f0a93135f742aac97cf82c1d96c
Reviewed-on: https://go-review.googlesource.com/c/go/+/397478
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit df89f2b)
Reviewed-on: https://go-review.googlesource.com/c/go/+/397594
Reviewed-by: Cherry Mui <cherryyz@google.com>
@bcmills bcmills mentioned this issue Sep 14, 2022
Closed
@golang golang locked and limited conversation to collaborators Apr 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages)
Projects
None yet
Milestone
Go1.19
Development

No branches or pull requests
6 participants
@dmitshur @rolandshoemaker @bcmills @hopehook @gopherbot @heschi